[epiphany] Fix partially-typed address appearing in subtitle
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] Fix partially-typed address appearing in subtitle
- Date: Wed, 17 Sep 2014 14:08:07 +0000 (UTC)
commit d6b767b7745c886c80ed82c5250ba1c11d2e8179
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Sun Sep 7 09:59:15 2014 -0500
Fix partially-typed address appearing in subtitle
Now that the EphyLocationController manages the address of the
EphyTitleBox in addition to the EphyLocationEntry, it's no longer safe
to update its address when the address of the location entry changes,
since we want the title box to display the address of the current page,
not whatever the user has typed into the location entry. This is easy to
fix by simply not updating the location controller's address with the
location entry's address.
https://bugzilla.gnome.org/show_bug.cgi?id=732713
src/ephy-location-controller.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/src/ephy-location-controller.c b/src/ephy-location-controller.c
index a281b47..b39e0ee 100644
--- a/src/ephy-location-controller.c
+++ b/src/ephy-location-controller.c
@@ -260,17 +260,13 @@ user_changed_cb (GtkWidget *widget, EphyLocationController *controller)
address = ephy_location_entry_get_location (EPHY_LOCATION_ENTRY (widget));
- LOG ("user_changed_cb, new address %s", address);
-
- g_signal_handlers_block_by_func (controller, G_CALLBACK (sync_address), widget);
- ephy_location_controller_set_address (controller, address);
+ LOG ("user_changed_cb, address %s", address);
completion = gtk_entry_get_completion (GTK_ENTRY (widget));
model = gtk_entry_completion_get_model (completion);
ephy_completion_model_update_for_string (EPHY_COMPLETION_MODEL (model), address,
update_done_cb, completion);
- g_signal_handlers_unblock_by_func (controller, G_CALLBACK (sync_address), widget);
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]