[mutter] Do xwayland/wayland window association in a later, not an idle
- From: Owen Taylor <otaylor src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [mutter] Do xwayland/wayland window association in a later, not an idle
- Date: Tue, 16 Sep 2014 17:45:17 +0000 (UTC)
commit 9c465a2d5a688ec0f514211e79cbc683f8acae4b
Author: Owen W. Taylor <otaylor fishsoup net>
Date: Mon Sep 15 15:15:27 2014 -0400
Do xwayland/wayland window association in a later, not an idle
g_idle_add() makes no guarantee about when it will be run - if Mutter
is busy drawing and blocking glXSwapBuffers() it could happen only
minutes later. Use meta_later_add (META_LATER_BEFORE_REDRAW) instead -
this will deterministically be run after the Wayland socket is read
from but before the next frame is painted.
https://bugzilla.gnome.org/show_bug.cgi?id=736694
src/wayland/meta-xwayland.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
---
diff --git a/src/wayland/meta-xwayland.c b/src/wayland/meta-xwayland.c
index 1910f79..48d4cf6 100644
--- a/src/wayland/meta-xwayland.c
+++ b/src/wayland/meta-xwayland.c
@@ -76,7 +76,7 @@ typedef struct {
MetaXWaylandManager *manager;
MetaWindow *window;
guint32 surface_id;
- guint idle_id;
+ guint later_id;
} AssociateWindowWithSurfaceOp;
static void
@@ -84,12 +84,12 @@ associate_window_with_surface_window_destroyed (gpointer user_data,
GObject *obj)
{
AssociateWindowWithSurfaceOp *op = user_data;
- g_source_remove (op->idle_id);
+ meta_later_remove (op->later_id);
g_free (op);
}
static gboolean
-associate_window_with_surface_idle (gpointer user_data)
+associate_window_with_surface_later (gpointer user_data)
{
AssociateWindowWithSurfaceOp *op = user_data;
if (!associate_window_with_surface_id (op->manager, op->window, op->surface_id))
@@ -113,15 +113,17 @@ meta_xwayland_handle_wl_surface_id (MetaWindow *window,
if (!associate_window_with_surface_id (manager, window, surface_id))
{
/* No surface ID yet... it should arrive after the next
- * iteration through the loop, so queue an idle and see
+ * iteration through the loop, so queue a later and see
* what happens.
*/
AssociateWindowWithSurfaceOp *op = g_new0 (AssociateWindowWithSurfaceOp, 1);
op->manager = manager;
op->window = window;
op->surface_id = surface_id;
- op->idle_id = g_idle_add (associate_window_with_surface_idle, op);
- g_source_set_name_by_id (op->idle_id, "[mutter] associate_window_with_surface_idle");
+ op->later_id = meta_later_add (META_LATER_BEFORE_REDRAW,
+ associate_window_with_surface_later,
+ op,
+ NULL);
g_object_weak_ref (G_OBJECT (op->window), associate_window_with_surface_window_destroyed, op);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]