[gnome-boxes] app: Setup brokers during activation



commit dc7b06cf5dfe326142d041e5f5c4ab874c0d0b87
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date:   Mon Sep 15 01:00:14 2014 +0100

    app: Setup brokers during activation
    
    Setup of brokers imply creation of Machine instances and they assume
    App.main_window to be non-null but App.main_window is only initialized
    for the first time during 'activate' so setup of brokers can easily
    crash Boxes if done through 'startup' (which happens before 'activate').

 src/app.vala |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/src/app.vala b/src/app.vala
index 63575f8..b6eda07 100644
--- a/src/app.vala
+++ b/src/app.vala
@@ -131,12 +131,6 @@ private class Boxes.App: Gtk.Application {
         if (Config.HAVE_OVIRT)
             brokers.insert ("ovirt", OvirtBroker.get_default ());
 
-        setup_sources.begin ((obj, result) => {
-            setup_sources.end (result);
-            is_ready = true;
-            ready ();
-        });
-
         check_cpu_vt_capability.begin ();
         check_module_kvm_loaded.begin ();
     }
@@ -162,6 +156,12 @@ private class Boxes.App: Gtk.Application {
 
         var window = add_new_window ();
         window.set_state (UIState.COLLECTION);
+
+        setup_sources.begin ((obj, result) => {
+            setup_sources.end (result);
+            is_ready = true;
+            ready ();
+        });
     }
 
     static bool opt_fullscreen;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]