[gnumeric] tests: improve roundtrip test diagnostics.
- From: Morten Welinder <mortenw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnumeric] tests: improve roundtrip test diagnostics.
- Date: Mon, 8 Sep 2014 15:26:54 +0000 (UTC)
commit 9a3dbb051431ebda1b42172609d6d801890e6f90
Author: Morten Welinder <terra gnome org>
Date: Mon Sep 8 11:29:07 2014 -0400
tests: improve roundtrip test diagnostics.
NEWS | 1 +
test/ChangeLog | 5 +++++
test/GnumericTest.pm | 3 +++
3 files changed, 9 insertions(+), 0 deletions(-)
---
diff --git a/NEWS b/NEWS
index e528a5b..d3e834b 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,7 @@ Morten:
* Fix xls export problem. [#733771]
* Update WEEKDAY function.
* Fix xlsx export problem for strings. [#736202]
+ * Text suite improvements.
--------------------------------------------------------------------------
Gnumeric 1.12.17
diff --git a/test/ChangeLog b/test/ChangeLog
index bf2729b..6a758e8 100644
--- a/test/ChangeLog
+++ b/test/ChangeLog
@@ -1,3 +1,8 @@
+2014-09-08 Morten Welinder <terra gnome org>
+
+ * GnumericTest.pm (test_roundtrip): Catch when ssconvert fails to
+ produce a file we expect.
+
2014-06-09 Morten Welinder <terra gnome org>
* Release 1.12.17
diff --git a/test/GnumericTest.pm b/test/GnumericTest.pm
index cf0d7e7..e43d442 100644
--- a/test/GnumericTest.pm
+++ b/test/GnumericTest.pm
@@ -404,6 +404,7 @@ sub test_roundtrip {
print STDERR "# $cmd\n" if $verbose;
$code = system ("$cmd 2>&1 | sed -e 's/^/| /'");
&system_failure ($ssconvert, $code) if $code;
+ die "Failed to produce $file_resized\n" unless -r $file_resized;
&junkfile ($file_resized) unless $keep;
}
@@ -415,6 +416,7 @@ sub test_roundtrip {
print "# $cmd\n" if $verbose;
my $code = system ("$cmd 2>&1 | sed -e 's/^/| /'");
&system_failure ($ssconvert, $code) if $code;
+ die "Failed to produce $tmp1\n" unless -r $tmp1;
}
my $tmp2 = "$tmp-new.$ext";
@@ -425,6 +427,7 @@ sub test_roundtrip {
print "# $cmd\n" if $verbose;
my $code = system ("$cmd 2>&1 | sed -e 's/^/| /'");
&system_failure ($ssconvert, $code) if $code;
+ die "Failed to produce $tmp2\n" unless -r $tmp2;
}
my $tmp_xml = "$tmp.xml";
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]