[gtksourceview/wip/undo-redo] UndoManager: new implementation based on GQueues (not finished)

[Sébastien Wilmet <swilmet src gnome org>]

commit f0a6c5db054ef8fb4b1ba0b7e42886e0ab3c5a42
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sun Aug 31 17:40:40 2014 +0200

    UndoManager: new implementation based on GQueues (not finished)

 gtksourceview/gtksourceundomanagerdefault.c |  833 ++++++++++++++++++++++++++-
 1 files changed, 824 insertions(+), 9 deletions(-)
---
diff --git a/gtksourceview/gtksourceundomanagerdefault.c b/gtksourceview/gtksourceundomanagerdefault.c
index f843613..195a880 100644
--- a/gtksourceview/gtksourceundomanagerdefault.c
+++ b/gtksourceview/gtksourceundomanagerdefault.c
@@ -43,7 +43,16 @@ typedef enum
 
 struct _ActionInsert
 {
-       gint pos;
+       /* The character offest where the insertion occurred. */
+       gint start;
+
+       /* When the text is inserted, the character offset of the end of 'text'.
+        * It is used to undo the insertion by deleting the text between 'start'
+        * and 'end'.
+        */
+       gint end;
+
+       /* nul-terminated text */
        gchar *text;
 };
 
@@ -74,6 +83,13 @@ struct _ActionGroup
         * gtk_text_buffer_end_user_action().
         */
        GQueue *actions;
+
+       /* If force_not_mergeable is FALSE, there are dynamic checks to see if
+        * the action group is mergeable. For example if the saved_location is
+        * just after the action group, the action group is not mergeable, so
+        * the saved_location isn't lost.
+        */
+       guint force_not_mergeable : 1;
 };
 
 struct _GtkSourceUndoManagerDefaultPrivate
@@ -116,6 +132,26 @@ struct _GtkSourceUndoManagerDefaultPrivate
 
        guint can_undo : 1;
        guint can_redo : 1;
+
+#if 0
+       /* Indicates that a new action group should be created for the next
+        * insertion or deletion.
+        */
+       guint create_action_group : 1;
+#endif
+
+       /* Whether we are between a begin-user-action and a end-user-action.
+        * Some operations, like undo and redo, are not allowed during a user
+        * action (it would screw up the history).
+        * At the beginning of a user action, a new action group is created. At
+        * the end of the user action, we try to merge the group with the
+        * previous one. So when an insertion or deletion occurs when
+        * running_user_action is TRUE, we don't need to create a new group. But
+        * when running_user_action is FALSE, we need to put the insertion or
+        * deletion into a new group and try to merge it directly with the
+        * previous group.
+        */
+       guint running_user_action : 1;
 };
 
 enum
@@ -127,6 +163,11 @@ enum
 
 static void gtk_source_undo_manager_iface_init (GtkSourceUndoManagerIface *iface);
 
+static void action_free (Action *action);
+
+static gboolean action_merge (Action *action,
+                             Action *new_action);
+
 G_DEFINE_TYPE_WITH_CODE (GtkSourceUndoManagerDefault,
                         gtk_source_undo_manager_default,
                         G_TYPE_OBJECT,
@@ -134,6 +175,538 @@ G_DEFINE_TYPE_WITH_CODE (GtkSourceUndoManagerDefault,
                          G_IMPLEMENT_INTERFACE (GTK_SOURCE_TYPE_UNDO_MANAGER,
                                                 gtk_source_undo_manager_iface_init))
 
+/* Utilities functions */
+
+static ActionGroup *
+action_group_new (void)
+{
+       ActionGroup *group;
+
+       group = g_slice_new (ActionGroup);
+       group->actions = g_queue_new ();
+       group->force_not_mergeable = FALSE;
+
+       return group;
+}
+
+static void
+action_group_free (ActionGroup *group)
+{
+       if (group != NULL)
+       {
+               g_queue_free_full (group->actions, (GDestroyNotify) action_free);
+               g_slice_free (ActionGroup, group);
+       }
+}
+
+/* Try to merge @new_group into @group. Returns TRUE if merged. It is up to the
+ * caller to free @new_group.
+ */
+static gboolean
+action_group_merge (ActionGroup *group,
+                   ActionGroup *new_group)
+{
+       Action *action;
+       Action *new_action;
+
+       if (group->force_not_mergeable ||
+           new_group->force_not_mergeable ||
+           group->actions->length > 1 ||
+           new_group->actions->length > 1)
+       {
+               return FALSE;
+       }
+
+       if (new_group->actions->length == 0)
+       {
+               return TRUE;
+       }
+
+       action = g_queue_peek_head (group->actions);
+       new_action = g_queue_peek_head (new_group->actions);
+
+       return action_merge (action, new_action);
+}
+
+/* Try to merge the current action group with the previous one. The "current
+ * action group" is the node on the left of location.
+ */
+static void
+try_merge_current_action_group (GtkSourceUndoManagerDefault *manager)
+{
+       GList *new_node;
+       GList *prev_node;
+       ActionGroup *new_group;
+       ActionGroup *prev_group;
+
+       if (manager->priv->location != NULL)
+       {
+               new_node = manager->priv->location->prev;
+       }
+       else
+       {
+               new_node = manager->priv->action_groups->tail;
+       }
+
+       g_assert (new_node != NULL);
+
+       prev_node = new_node->prev;
+
+       if (prev_node == NULL)
+       {
+               return;
+       }
+
+       new_group = new_node->data;
+       prev_group = prev_node->data;
+
+       /* If the previous group is empty, it means that it was not correctly
+        * merged.
+        */
+       g_assert (prev_group->actions->length > 0);
+
+       /* If the saved_location is between the two nodes, the two nodes cannot
+        * be merged. Except if the new node is empty.
+        */
+       if (manager->priv->has_saved_location &&
+           manager->priv->saved_location == new_node &&
+           new_group->actions->length > 0)
+       {
+               return;
+       }
+
+       if (action_group_merge (prev_group, new_group))
+       {
+               if (manager->priv->has_saved_location &&
+                   manager->priv->saved_location == new_node)
+               {
+                       manager->priv->saved_location = new_node->next;
+               }
+
+               /* Of course, no need to update location, since new_node is on
+                * the left of location.
+                */
+               g_assert (manager->priv->location != new_node);
+
+               action_group_free (new_group);
+               g_queue_delete_link (manager->priv->action_groups, new_node);
+       }
+}
+
+static void
+update_can_undo_can_redo (GtkSourceUndoManagerDefault *manager)
+{
+       gboolean can_undo;
+       gboolean can_redo;
+
+       if (manager->priv->running_user_action)
+       {
+               can_undo = FALSE;
+               can_redo = FALSE;
+       }
+       else if (manager->priv->location != NULL)
+       {
+               can_undo = manager->priv->location->prev != NULL;
+               can_redo = TRUE;
+       }
+       else
+       {
+               can_undo = manager->priv->action_groups->tail != NULL;
+               can_redo = FALSE;
+       }
+
+       if (manager->priv->can_undo != can_undo)
+       {
+               manager->priv->can_undo = can_undo;
+               gtk_source_undo_manager_can_undo_changed (GTK_SOURCE_UNDO_MANAGER (manager));
+       }
+
+       if (manager->priv->can_redo != can_redo)
+       {
+               manager->priv->can_redo = can_redo;
+               gtk_source_undo_manager_can_redo_changed (GTK_SOURCE_UNDO_MANAGER (manager));
+       }
+}
+
+static void
+clear_all (GtkSourceUndoManagerDefault *manager)
+{
+       GList *l;
+
+       if (manager->priv->has_saved_location &&
+           manager->priv->saved_location != manager->priv->location)
+       {
+               manager->priv->has_saved_location = FALSE;
+       }
+
+       for (l = manager->priv->action_groups->head; l != NULL; l = l->next)
+       {
+               ActionGroup *group = l->data;
+               action_group_free (group);
+       }
+
+       g_queue_clear (manager->priv->action_groups);
+       manager->priv->location = NULL;
+       manager->priv->saved_location = NULL;
+
+       update_can_undo_can_redo (manager);
+}
+
+static void
+remove_last_action_group (GtkSourceUndoManagerDefault *manager)
+{
+       ActionGroup *group;
+
+       if (manager->priv->action_groups->length == 0)
+       {
+               return;
+       }
+
+       if (manager->priv->location == manager->priv->action_groups->tail)
+       {
+               manager->priv->location = NULL;
+       }
+
+       if (manager->priv->has_saved_location)
+       {
+               if (manager->priv->saved_location == NULL)
+               {
+                       manager->priv->has_saved_location = FALSE;
+               }
+               else if (manager->priv->saved_location == manager->priv->action_groups->tail)
+               {
+                       manager->priv->saved_location = NULL;
+               }
+       }
+
+       group = g_queue_pop_tail (manager->priv->action_groups);
+       action_group_free (group);
+}
+
+static void
+insert_new_action_group (GtkSourceUndoManagerDefault *manager)
+{
+       ActionGroup *group = action_group_new ();
+
+       if (manager->priv->location != NULL)
+       {
+               g_queue_insert_before (manager->priv->action_groups,
+                                      manager->priv->location,
+                                      group);
+       }
+       else
+       {
+               g_queue_push_tail (manager->priv->action_groups,
+                                  group);
+       }
+
+       if (manager->priv->has_saved_location &&
+           manager->priv->saved_location == manager->priv->location)
+       {
+               if (manager->priv->saved_location != NULL)
+               {
+                       manager->priv->saved_location = manager->priv->saved_location->prev;
+               }
+               else
+               {
+                       manager->priv->saved_location = manager->priv->action_groups->tail;
+               }
+
+               g_assert (manager->priv->saved_location != NULL);
+               g_assert (manager->priv->saved_location->data == group);
+       }
+}
+
+static void
+remove_redo_action_groups (GtkSourceUndoManagerDefault *manager)
+{
+       while (manager->priv->location != NULL)
+       {
+               remove_last_action_group (manager);
+       }
+}
+
+static void
+insert_action (GtkSourceUndoManagerDefault *manager,
+              Action                      *new_action)
+{
+       ActionGroup *group;
+       Action *prev_action;
+
+       g_assert (new_action != NULL);
+
+       remove_redo_action_groups (manager);
+       g_assert (manager->priv->location == NULL);
+
+       if (!manager->priv->running_user_action)
+       {
+               insert_new_action_group (manager);
+       }
+
+       group = g_queue_peek_tail (manager->priv->action_groups);
+       g_assert (group != NULL);
+
+       prev_action = g_queue_peek_tail (group->actions);
+
+       if (prev_action != NULL &&
+           action_merge (prev_action, new_action))
+       {
+               action_free (new_action);
+       }
+       else
+       {
+               g_queue_push_tail (group->actions, new_action);
+       }
+
+       if (!manager->priv->running_user_action)
+       {
+               try_merge_current_action_group (manager);
+       }
+
+       update_can_undo_can_redo (manager);
+}
+
+static void
+delete_text (GtkTextBuffer *buffer,
+            gint           start,
+            gint           end)
+{
+       GtkTextIter start_iter;
+       GtkTextIter end_iter;
+
+       gtk_text_buffer_get_iter_at_offset (buffer, &start_iter, start);
+       gtk_text_buffer_get_iter_at_offset (buffer, &end_iter, end);
+
+       gtk_text_buffer_begin_user_action (buffer);
+       gtk_text_buffer_delete (buffer, &start_iter, &end_iter);
+       gtk_text_buffer_end_user_action (buffer);
+}
+
+static void
+insert_text (GtkTextBuffer *buffer,
+            gint           offset,
+            const gchar   *text)
+{
+       GtkTextIter iter;
+
+       gtk_text_buffer_get_iter_at_offset (buffer, &iter, offset);
+
+       gtk_text_buffer_begin_user_action (buffer);
+       gtk_text_buffer_insert (buffer, &iter, text, -1);
+       gtk_text_buffer_end_user_action (buffer);
+}
+
+/* ActionInsert implementation */
+
+static Action *
+action_insert_new (void)
+{
+       Action *action;
+
+       action = g_slice_new0 (Action);
+       action->action_type = ACTION_TYPE_INSERT;
+
+       return action;
+}
+
+static void
+action_insert_free (Action *action)
+{
+       g_assert (action->action_type == ACTION_TYPE_INSERT);
+
+       g_free (action->action.insert.text);
+       g_slice_free (Action, action);
+}
+
+static void
+action_insert_undo (GtkTextBuffer *buffer,
+                   Action        *action)
+{
+       g_assert (action->action_type == ACTION_TYPE_INSERT);
+
+       delete_text (buffer,
+                    action->action.insert.start,
+                    action->action.insert.end);
+}
+
+static void
+action_insert_redo (GtkTextBuffer *buffer,
+                   Action        *action)
+{
+       g_assert (action->action_type == ACTION_TYPE_INSERT);
+
+       insert_text (buffer,
+                    action->action.insert.start,
+                    action->action.insert.text);
+}
+
+static gboolean
+action_insert_merge (Action *action,
+                    Action *new_action)
+{
+       g_assert (action->action_type == ACTION_TYPE_INSERT);
+       g_assert (new_action->action_type == ACTION_TYPE_INSERT);
+
+       return FALSE;
+}
+
+/* ActionDelete implementation */
+
+static Action *
+action_delete_new (void)
+{
+       Action *action;
+
+       action = g_slice_new0 (Action);
+       action->action_type = ACTION_TYPE_DELETE;
+
+       return action;
+}
+
+static void
+action_delete_free (Action *action)
+{
+       g_assert (action->action_type == ACTION_TYPE_DELETE);
+
+       g_free (action->action.delete.text);
+       g_slice_free (Action, action);
+}
+
+static void
+action_delete_undo (GtkTextBuffer *buffer,
+                   Action        *action)
+{
+       g_assert (action->action_type == ACTION_TYPE_DELETE);
+
+       insert_text (buffer,
+                    action->action.delete.start,
+                    action->action.delete.text);
+}
+
+static void
+action_delete_redo (GtkTextBuffer *buffer,
+                   Action        *action)
+{
+       g_assert (action->action_type == ACTION_TYPE_DELETE);
+
+       delete_text (buffer,
+                    action->action.delete.start,
+                    action->action.delete.end);
+}
+
+static gboolean
+action_delete_merge (Action *action,
+                    Action *new_action)
+{
+       g_assert (action->action_type == ACTION_TYPE_DELETE);
+       g_assert (new_action->action_type == ACTION_TYPE_DELETE);
+
+       return FALSE;
+}
+
+/* Action interface.
+ * The Action struct can be seen as an interface. All the explicit case analysis
+ * on the action type are grouped in this code section. This can easily be
+ * modified as an object-oriented architecture with polymorphism.
+ */
+
+static void
+action_free (Action *action)
+{
+       if (action == NULL)
+       {
+               return;
+       }
+
+       switch (action->action_type)
+       {
+               case ACTION_TYPE_INSERT:
+                       action_insert_free (action);
+                       break;
+
+               case ACTION_TYPE_DELETE:
+                       action_delete_free (action);
+                       break;
+
+               default:
+                       g_return_if_reached ();
+                       break;
+       }
+}
+
+static void
+action_undo (GtkTextBuffer *buffer,
+            Action        *action)
+{
+       g_assert (action != NULL);
+
+       switch (action->action_type)
+       {
+               case ACTION_TYPE_INSERT:
+                       action_insert_undo (buffer, action);
+                       break;
+
+               case ACTION_TYPE_DELETE:
+                       action_delete_undo (buffer, action);
+                       break;
+
+               default:
+                       g_return_if_reached ();
+                       break;
+       }
+}
+
+static void
+action_redo (GtkTextBuffer *buffer,
+            Action        *action)
+{
+       g_assert (action != NULL);
+
+       switch (action->action_type)
+       {
+               case ACTION_TYPE_INSERT:
+                       action_insert_redo (buffer, action);
+                       break;
+
+               case ACTION_TYPE_DELETE:
+                       action_delete_redo (buffer, action);
+                       break;
+
+               default:
+                       g_return_if_reached ();
+                       break;
+       }
+}
+
+/* Try to merge @new_action into @action. Returns TRUE if merged. It is up to
+ * the caller to free @new_action if needed.
+ */
+static gboolean
+action_merge (Action *action,
+             Action *new_action)
+{
+       g_assert (action != NULL);
+       g_assert (new_action != NULL);
+
+       if (action->action_type != new_action->action_type)
+       {
+               return FALSE;
+       }
+
+       switch (action->action_type)
+       {
+               case ACTION_TYPE_INSERT:
+                       return action_insert_merge (action, new_action);
+
+               case ACTION_TYPE_DELETE:
+                       return action_delete_merge (action, new_action);
+
+               default:
+                       g_return_val_if_reached (FALSE);
+                       break;
+       }
+}
+
 /* Buffer signal handlers */
 
 static void
@@ -143,6 +716,20 @@ insert_text_cb (GtkTextBuffer               *buffer,
                gint                         length,
                GtkSourceUndoManagerDefault *manager)
 {
+       Action *action = action_insert_new ();
+       gint start;
+       gchar *text_copy;
+
+       start = gtk_text_iter_get_offset (location);
+       action->action.insert.start = start;
+
+       /* text_copy is nul-terminated. */
+       text_copy = g_strndup (text, length);
+       action->action.insert.text = text_copy;
+
+       action->action.insert.end = start + g_utf8_strlen (text_copy, -1);
+
+       insert_action (manager, action);
 }
 
 static void
@@ -151,18 +738,121 @@ delete_range_cb (GtkTextBuffer               *buffer,
                 GtkTextIter                 *end,
                 GtkSourceUndoManagerDefault *manager)
 {
+       Action *action = action_delete_new ();
+
+       action->action.delete.start = gtk_text_iter_get_offset (start);
+       action->action.delete.end = gtk_text_iter_get_offset (end);
+       action->action.insert.text = gtk_text_buffer_get_slice (buffer, start, end, TRUE);
+
+       insert_action (manager, action);
 }
 
 static void
 begin_user_action_cb (GtkTextBuffer               *buffer,
                      GtkSourceUndoManagerDefault *manager)
 {
+       insert_new_action_group (manager);
+
+       manager->priv->running_user_action = TRUE;
+       update_can_undo_can_redo (manager);
+}
+
+static void
+end_user_action_cb (GtkTextBuffer               *buffer,
+                   GtkSourceUndoManagerDefault *manager)
+{
+       try_merge_current_action_group (manager);
+
+       manager->priv->running_user_action = FALSE;
+       update_can_undo_can_redo (manager);
 }
 
 static void
 modified_changed_cb (GtkTextBuffer               *buffer,
                     GtkSourceUndoManagerDefault *manager)
 {
+       /* TODO verify that the insertion or deletion occurs before the
+        * call to gtk_text_buffer_set_modified(), so that location is
+        * updated before.
+        */
+
+       if (gtk_text_buffer_get_modified (buffer))
+       {
+               /* It can happen for example when the file on disk has been
+                * deleted.
+                */
+               if (manager->priv->has_saved_location &&
+                   manager->priv->saved_location == manager->priv->location)
+               {
+                       manager->priv->has_saved_location = FALSE;
+               }
+       }
+
+       /* saved */
+       else
+       {
+               manager->priv->saved_location = manager->priv->location;
+               manager->priv->has_saved_location = TRUE;
+
+               /* Saving a buffer during a user action is allowed, the user
+                * action is split.
+                * FIXME or a warning should be printed? It would simplify a
+                * little the code.
+                */
+               if (manager->priv->running_user_action)
+               {
+                       try_merge_current_action_group (manager);
+                       insert_new_action_group (manager);
+               }
+       }
+}
+
+static void
+block_signal_handlers (GtkSourceUndoManagerDefault *manager)
+{
+       g_signal_handlers_block_by_func (manager->priv->buffer,
+                                        insert_text_cb,
+                                        manager);
+
+       g_signal_handlers_block_by_func (manager->priv->buffer,
+                                        delete_range_cb,
+                                        manager);
+
+       g_signal_handlers_block_by_func (manager->priv->buffer,
+                                        begin_user_action_cb,
+                                        manager);
+
+       g_signal_handlers_block_by_func (manager->priv->buffer,
+                                        end_user_action_cb,
+                                        manager);
+
+       g_signal_handlers_block_by_func (manager->priv->buffer,
+                                        modified_changed_cb,
+                                        manager);
+}
+
+static void
+unblock_signal_handlers (GtkSourceUndoManagerDefault *manager)
+{
+       g_signal_handlers_unblock_by_func (manager->priv->buffer,
+                                          insert_text_cb,
+                                          manager);
+
+       g_signal_handlers_unblock_by_func (manager->priv->buffer,
+                                          delete_range_cb,
+                                          manager);
+
+       g_signal_handlers_unblock_by_func (manager->priv->buffer,
+                                          begin_user_action_cb,
+                                          manager);
+
+       g_signal_handlers_unblock_by_func (manager->priv->buffer,
+                                          end_user_action_cb,
+                                          manager);
+
+       g_signal_handlers_unblock_by_func (manager->priv->buffer,
+                                          modified_changed_cb,
+                                          manager);
 }
 
 static void
@@ -200,10 +890,18 @@ set_buffer (GtkSourceUndoManagerDefault *manager,
                                 0);
 
        g_signal_connect_object (buffer,
+                                "end-user-action",
+                                G_CALLBACK (end_user_action_cb),
+                                manager,
+                                0);
+
+       g_signal_connect_object (buffer,
                                 "modified-changed",
                                 G_CALLBACK (modified_changed_cb),
                                 manager,
                                 0);
+
+       modified_changed_cb (manager->priv->buffer, manager);
 }
 
 /* GObject construction, destruction and properties */
@@ -275,6 +973,11 @@ gtk_source_undo_manager_default_dispose (GObject *object)
 static void
 gtk_source_undo_manager_default_finalize (GObject *object)
 {
+       GtkSourceUndoManagerDefault *manager = GTK_SOURCE_UNDO_MANAGER_DEFAULT (object);
+
+       g_queue_free_full (manager->priv->action_groups,
+                          (GDestroyNotify) action_group_free);
+
        G_OBJECT_CLASS (gtk_source_undo_manager_default_parent_class)->finalize (object);
 }
 
@@ -311,40 +1014,152 @@ static void
 gtk_source_undo_manager_default_init (GtkSourceUndoManagerDefault *manager)
 {
        manager->priv = gtk_source_undo_manager_default_get_instance_private (manager);
+
+       manager->priv->action_groups = g_queue_new ();
 }
 
 /* Interface implementation */
 
 static gboolean
-gtk_source_undo_manager_can_undo_impl (GtkSourceUndoManager *manager)
+gtk_source_undo_manager_can_undo_impl (GtkSourceUndoManager *undo_manager)
 {
-       return GTK_SOURCE_UNDO_MANAGER_DEFAULT (manager)->priv->can_undo;
+       GtkSourceUndoManagerDefault *manager = GTK_SOURCE_UNDO_MANAGER_DEFAULT (undo_manager);
+       return manager->priv->can_undo;
 }
 
 static gboolean
-gtk_source_undo_manager_can_redo_impl (GtkSourceUndoManager *manager)
+gtk_source_undo_manager_can_redo_impl (GtkSourceUndoManager *undo_manager)
 {
-       return GTK_SOURCE_UNDO_MANAGER_DEFAULT (manager)->priv->can_redo;
+       GtkSourceUndoManagerDefault *manager = GTK_SOURCE_UNDO_MANAGER_DEFAULT (undo_manager);
+       return manager->priv->can_redo;
 }
 
 static void
-gtk_source_undo_manager_undo_impl (GtkSourceUndoManager *manager)
+gtk_source_undo_manager_undo_impl (GtkSourceUndoManager *undo_manager)
 {
+       GtkSourceUndoManagerDefault *manager = GTK_SOURCE_UNDO_MANAGER_DEFAULT (undo_manager);
+       GList *old_location;
+       GList *new_location;
+       ActionGroup *group;
+       GList *l;
+
+       g_return_if_fail (manager->priv->can_undo);
+
+       old_location = manager->priv->location;
+
+       if (old_location != NULL)
+       {
+               new_location = manager->priv->location->prev;
+       }
+       else
+       {
+               new_location = manager->priv->action_groups->tail;
+       }
+
+       g_assert (new_location != NULL);
+       group = new_location->data;
+
+       /* Empty groups are inserted at the beginning of a user action, but
+        * during a user action can_undo is FALSE.
+        */
+       g_assert (group->actions->length > 0);
+
+       block_signal_handlers (manager);
+
+       for (l = group->actions->tail; l != NULL; l = l->prev)
+       {
+               Action *action = l->data;
+               action_undo (manager->priv->buffer, action);
+       }
+
+       if (manager->priv->has_saved_location)
+       {
+               if (old_location == manager->priv->saved_location)
+               {
+                       gtk_text_buffer_set_modified (manager->priv->buffer, TRUE);
+               }
+               else if (new_location == manager->priv->saved_location)
+               {
+                       gtk_text_buffer_set_modified (manager->priv->buffer, FALSE);
+               }
+       }
+
+       unblock_signal_handlers (manager);
+
+       manager->priv->location = new_location;
+       update_can_undo_can_redo (manager);
 }
 
 static void
-gtk_source_undo_manager_redo_impl (GtkSourceUndoManager *manager)
+gtk_source_undo_manager_redo_impl (GtkSourceUndoManager *undo_manager)
 {
+       GtkSourceUndoManagerDefault *manager = GTK_SOURCE_UNDO_MANAGER_DEFAULT (undo_manager);
+       GList *old_location;
+       GList *new_location;
+       ActionGroup *group;
+       GList *l;
+
+       g_return_if_fail (manager->priv->can_redo);
+
+       old_location = manager->priv->location;
+       g_assert (old_location != NULL);
+
+       new_location = old_location->next;
+
+       group = old_location->data;
+
+       block_signal_handlers (manager);
+
+       for (l = group->actions->head; l != NULL; l = l->next)
+       {
+               Action *action = l->data;
+               action_redo (manager->priv->buffer, action);
+       }
+
+       if (manager->priv->has_saved_location)
+       {
+               if (old_location == manager->priv->saved_location)
+               {
+                       gtk_text_buffer_set_modified (manager->priv->buffer, TRUE);
+               }
+               else if (new_location == manager->priv->saved_location)
+               {
+                       gtk_text_buffer_set_modified (manager->priv->buffer, FALSE);
+               }
+       }
+
+       unblock_signal_handlers (manager);
+
+       manager->priv->location = new_location;
+       update_can_undo_can_redo (manager);
 }
 
 static void
-gtk_source_undo_manager_begin_not_undoable_action_impl (GtkSourceUndoManager *manager)
+gtk_source_undo_manager_begin_not_undoable_action_impl (GtkSourceUndoManager *undo_manager)
 {
+       GtkSourceUndoManagerDefault *manager = GTK_SOURCE_UNDO_MANAGER_DEFAULT (undo_manager);
+       manager->priv->running_not_undoable_actions++;
+
+       if (manager->priv->running_not_undoable_actions == 1)
+       {
+               block_signal_handlers (manager);
+       }
 }
 
 static void
-gtk_source_undo_manager_end_not_undoable_action_impl (GtkSourceUndoManager *manager)
+gtk_source_undo_manager_end_not_undoable_action_impl (GtkSourceUndoManager *undo_manager)
 {
+       GtkSourceUndoManagerDefault *manager = GTK_SOURCE_UNDO_MANAGER_DEFAULT (undo_manager);
+
+       g_return_if_fail (manager->priv->running_not_undoable_actions > 0);
+
+       manager->priv->running_not_undoable_actions--;
+
+       if (manager->priv->running_not_undoable_actions == 0)
+       {
+               unblock_signal_handlers (manager);
+               clear_all (manager);
+       }
 }
 
 static void