[dia] [scan-build] Result of operation is garbage or undefined (invalid)

[Hans Breuer <hans src gnome org>]

commit 15f3ab42595506957d5c3eedb456d55b388b1612
Author: Hans Breuer <hans breuer org>
Date:   Fri Sep 5 16:11:05 2014 +0200

    [scan-build] Result of operation is garbage or undefined (invalid)
    
    Help scan-build to understand constraints on handles, too.
    
    The left operand of '-' is a garbage value
    File: /home/hb/from-git/dia/tests/test-objects.c
    Line: 244

 tests/test-objects.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/tests/test-objects.c b/tests/test-objects.c
index c66bdbe..bca9523 100644
--- a/tests/test-objects.c
+++ b/tests/test-objects.c
@@ -198,6 +198,8 @@ _test_movement (gconstpointer user_data)
    * about the first and second loop over it being different.
    */
   const int num_connections = o->num_connections;
+  /* same for the number of handles */
+  const int num_handles = o->num_handles;
 
   /* does the object move ... ? */
   from = o->position;
@@ -223,10 +225,10 @@ _test_movement (gconstpointer user_data)
   pos = o->position;
   bbox1 = o->bounding_box;
   /* remember handle and connection point positions ... */
-  handle_positions = g_alloca (sizeof(Point) * o->num_handles);
+  handle_positions = g_alloca (sizeof(Point) * num_handles);
   /* at least one handle is mandatory */
-  g_assert (o->num_handles > 0);
-  for (i = 0; i < o->num_handles; ++i)
+  g_assert (num_handles > 0);
+  for (i = 0; i < num_handles; ++i)
     handle_positions[i] = o->handles[i]->pos;
   cp_positions = g_alloca (sizeof(Point) * o->num_connections);
   for (i = 0; i < num_connections; ++i)
@@ -240,7 +242,7 @@ _test_movement (gconstpointer user_data)
   g_assert (   fabs(fabs(pos.x - o->position.x) - fabs(from.x - to.x)) < EPSILON
             && fabs(fabs(pos.y - o->position.y) - fabs(from.y - to.y)) < EPSILON );
   /* ... also for handles and connection points? */
-  for (i = 0; i < o->num_handles; ++i)
+  for (i = 0; i < num_handles; ++i)
     g_assert (   fabs(fabs(handle_positions[i].x - o->handles[i]->pos.x) - fabs(from.x - to.x)) < EPSILON
               && fabs(fabs(handle_positions[i].y - o->handles[i]->pos.y) - fabs(from.y - to.y)) < EPSILON);
   for (i = 0; i < num_connections; ++i)