[gnome-shell] search: Remove DND code from GridSearchResult
- From: Carlos Soriano <csoriano src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] search: Remove DND code from GridSearchResult
- Date: Mon, 1 Sep 2014 22:08:11 +0000 (UTC)
commit 3981b27d8f0351eac0307e0864154e4ba4d726b6
Author: Florian Müllner <fmuellner gnome org>
Date: Thu Aug 21 12:17:46 2014 +0200
search: Remove DND code from GridSearchResult
Providers that need drag-and-drop behavior can implement this via the
createResultObject() hook (as the app search provider already does), no
need to duplicate that code in the generic result objects
(ListSearchResult already does not implement DND).
https://bugzilla.gnome.org/show_bug.cgi?id=734726
js/ui/appDisplay.js | 8 --------
js/ui/search.js | 31 -------------------------------
2 files changed, 0 insertions(+), 39 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 24d386d..6640966 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1054,14 +1054,6 @@ const AppSearchProvider = new Lang.Class({
this.getInitialResultSet(terms, callback, cancellable);
},
- dragActivateResult: function(id, params) {
- params = Params.parse(params, { workspace: -1,
- timestamp: 0 });
-
- let app = this._appSys.lookup_app(id);
- app.open_new_window(workspace);
- },
-
createResultObject: function (resultMeta) {
let app = this._appSys.lookup_app(resultMeta['id']);
return new AppIcon(app);
diff --git a/js/ui/search.js b/js/ui/search.js
index 3278c8f..47ab3ac 100644
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -230,37 +230,6 @@ const GridSearchResult = new Lang.Class({
let content = new St.Bin({ child: this.icon.actor });
this.actor.set_child(content);
this.actor.label_actor = this.icon.label;
-
- let draggable = DND.makeDraggable(this.actor);
- draggable.connect('drag-begin',
- Lang.bind(this, function() {
- Main.overview.beginItemDrag(this);
- }));
- draggable.connect('drag-cancelled',
- Lang.bind(this, function() {
- Main.overview.cancelledItemDrag(this);
- }));
- draggable.connect('drag-end',
- Lang.bind(this, function() {
- Main.overview.endItemDrag(this);
- }));
-
- this._dragActorSource = content;
- },
-
- getDragActorSource: function() {
- return this._dragActorSource;
- },
-
- getDragActor: function() {
- return this.metaInfo['createIcon'](Main.overview.dashIconSize);
- },
-
- shellWorkspaceLaunch: function(params) {
- if (this.provider.dragActivateResult)
- this.provider.dragActivateResult(this.metaInfo.id, params);
- else
- this.provider.activateResult(this.metaInfo.id, this.terms);
}
});
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]