[mutter/wip/gtk-theming: 4/20] theme: Add titlebar_spacing

[Florian Müllner <fmuellner src gnome org>]

commit 59a48df2584f973acf2a3b73a0f3983f22993f2e
Author: Florian Müllner <fmuellner gnome org>
Date:   Wed Oct 1 05:44:19 2014 +0200

    theme: Add titlebar_spacing
    
    Rather than defining the space to the left and right of buttons, add a
    simple spacing property that defines the space between buttons, which is
    what GTK+ does for client-side decorations (e.g. GtkButtons in a GtkBox).
    Unfortunately the value is hardcoded in GTK+; if it is exposed in the
    theme in the future, we should pick it up from there, but for now we
    just use the same value as GTK+.

 src/ui/theme-private.h |    3 +++
 src/ui/theme.c         |   22 +++++++++++++---------
 2 files changed, 16 insertions(+), 9 deletions(-)
---
diff --git a/src/ui/theme-private.h b/src/ui/theme-private.h
index 178772f..bd482ba 100644
--- a/src/ui/theme-private.h
+++ b/src/ui/theme-private.h
@@ -181,6 +181,9 @@ struct _MetaFrameLayout
   /** Space around buttons */
   GtkBorder button_border;
 
+  /** Space between titlebar elements */
+  guint titlebar_spacing;
+
   /** scale factor for title text */
   double title_scale;
 
diff --git a/src/ui/theme.c b/src/ui/theme.c
index dcf6cf0..2c954a6 100644
--- a/src/ui/theme.c
+++ b/src/ui/theme.c
@@ -137,6 +137,7 @@ meta_frame_layout_new  (void)
   layout->button_width = -1;
   layout->button_height = -1;
 
+  layout->titlebar_spacing = 6; /* hardcoded in GTK+ */
   layout->has_title = TRUE;
   layout->title_scale = 1.0;
 
@@ -682,13 +683,11 @@ meta_frame_layout_calc_geometry (const MetaFrameLayout  *layout,
 
       space_used_by_buttons += button_width * n_left;
       space_used_by_buttons += (button_width * 0.75) * n_left_spacers;
-      space_used_by_buttons += layout->button_border.left * n_left;
-      space_used_by_buttons += layout->button_border.right * n_left;
+      space_used_by_buttons += layout->titlebar_spacing * MAX (n_left - 1, 0);
 
       space_used_by_buttons += button_width * n_right;
       space_used_by_buttons += (button_width * 0.75) * n_right_spacers;
-      space_used_by_buttons += layout->button_border.left * n_right;
-      space_used_by_buttons += layout->button_border.right * n_right;
+      space_used_by_buttons += layout->titlebar_spacing * MAX (n_right - 1, 0);
 
       if (space_used_by_buttons <= space_available)
         break; /* Everything fits, bail out */
@@ -785,7 +784,7 @@ meta_frame_layout_calc_geometry (const MetaFrameLayout  *layout,
         break;
 
       rect = right_func_rects[i];
-      rect->visible.x = x - layout->button_border.right - button_width;
+      rect->visible.x = x - button_width;
       if (right_buttons_has_spacer[i])
         rect->visible.x -= (button_width * 0.75);
 
@@ -803,7 +802,7 @@ meta_frame_layout_calc_geometry (const MetaFrameLayout  *layout,
           rect->clickable.height = button_height + button_y;
 
           if (i == n_right - 1)
-            rect->clickable.width += layout->right_titlebar_edge + layout->right_width + 
layout->button_border.right;
+            rect->clickable.width += layout->right_titlebar_edge + layout->right_width;
 
         }
       else
@@ -811,7 +810,10 @@ meta_frame_layout_calc_geometry (const MetaFrameLayout  *layout,
 
       *(right_bg_rects[i]) = rect->visible;
 
-      x = rect->visible.x - layout->button_border.left;
+      x = rect->visible.x;
+
+      if (i > 0)
+        x -= layout->titlebar_spacing;
 
       --i;
     }
@@ -829,7 +831,7 @@ meta_frame_layout_calc_geometry (const MetaFrameLayout  *layout,
 
       rect = left_func_rects[i];
 
-      rect->visible.x = x + layout->button_border.left;
+      rect->visible.x = x;
       rect->visible.y = button_y;
       rect->visible.width = button_width;
       rect->visible.height = button_height;
@@ -853,7 +855,9 @@ meta_frame_layout_calc_geometry (const MetaFrameLayout  *layout,
       else
         g_memmove (&(rect->clickable), &(rect->visible), sizeof(rect->clickable));
 
-      x = rect->visible.x + rect->visible.width + layout->button_border.right;
+      x = rect->visible.x + rect->visible.width;
+      if (i < n_left - 1)
+        x += layout->titlebar_spacing;
       if (left_buttons_has_spacer[i])
         x += (button_width * 0.75);