[gnumeric] XLS: Don't free object we don't own.
- From: Morten Welinder <mortenw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnumeric] XLS: Don't free object we don't own.
- Date: Wed, 29 Oct 2014 21:03:46 +0000 (UTC)
commit cd362e60f45078c78cb68a7e52c999c3479e042c
Author: Morten Welinder <terra gnome org>
Date: Wed Oct 29 17:02:33 2014 -0400
XLS: Don't free object we don't own.
plugins/excel/ChangeLog | 4 ++++
plugins/excel/ms-chart.c | 5 +----
2 files changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/plugins/excel/ChangeLog b/plugins/excel/ChangeLog
index 3750443..1f9ec8d 100644
--- a/plugins/excel/ChangeLog
+++ b/plugins/excel/ChangeLog
@@ -1,3 +1,7 @@
+2014-10-28 Morten Welinder <terra gnome org>
+
+ * ms-chart.c (ms_excel_chart_read): Fix double free.
+
2014-10-27 Jean Brefort <jean brefort normalesup org>
* xlsx-read-drawing.c (xlsx_axis_format): add some support for axis format.
diff --git a/plugins/excel/ms-chart.c b/plugins/excel/ms-chart.c
index 2017fa6..e7a15fa 100644
--- a/plugins/excel/ms-chart.c
+++ b/plugins/excel/ms-chart.c
@@ -3773,10 +3773,7 @@ ms_excel_chart_read (BiffQuery *q, MSContainer *container,
ms_container_finalize (&state.container);
if (state.error) {
- if (state.graph) {
- g_object_unref (state.graph);
- state.graph = NULL;
- }
+ state.graph = NULL;
state.chart = NULL;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]