[gnome-boxes/gnome-3-14] snapshots-list-row: Always display msg when reverting



commit 7dd8933ad046222a971cce57d7943af91c093ada
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date:   Fri Oct 24 13:00:17 2014 +0100

    snapshots-list-row: Always display msg when reverting
    
    We were not displaying "Reverting to SNAPSHOT_NAME" message and spinner
    if machine was not in running state. The rationale was that in
    non-running state, reverting is a very quick operation and therefore the
    stack page switch animation looked weird.
    
    However reverting is not always very fast in this case and the missing
    indication is a bit of a UX failure when that happens. Moreover, the
    quick page switch doesn't look that weird after all. If we decide to
    still address the latter, we can always introduce a very short artificial
    delay.

 src/snapshot-list-row.vala |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/src/snapshot-list-row.vala b/src/snapshot-list-row.vala
index 2bf579f..3f9342b 100644
--- a/src/snapshot-list-row.vala
+++ b/src/snapshot-list-row.vala
@@ -142,9 +142,7 @@ private class Boxes.SnapshotListRow : Gtk.ListBoxRow {
             snapshot_state = snapshot_config.get_state ();
         } catch (GLib.Error e) {}
 
-        var show_activity = (machine.state == Machine.MachineState.RUNNING);
-        if (show_activity)
-            activity_message = _("Reverting to %s…").printf (snapshot_name);
+        activity_message = _("Reverting to %s…").printf (snapshot_name);
 
         if (machine.window.previous_ui_state == UIState.DISPLAY &&
             snapshot_state == GVirConfig.DomainSnapshotDomainState.SHUTOFF) {
@@ -164,8 +162,7 @@ private class Boxes.SnapshotListRow : Gtk.ListBoxRow {
                 warning (e.message);
                 machine.window.notificationbar.display_error (_("Failed to apply snapshot"));
             }
-            if (show_activity)
-                activity_message = null;
+            activity_message = null;
         });
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]