[network-manager-applet/th/bgo739246_clang: 2/10] c-e: fix passing wrong enum type to gtk_widget_override_background_color()
- From: Thomas Haller <thaller src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-applet/th/bgo739246_clang: 2/10] c-e: fix passing wrong enum type to gtk_widget_override_background_color()
- Date: Mon, 27 Oct 2014 14:50:24 +0000 (UTC)
commit 3fc750af4624dbc74290513f41bd9c0ea21c6853
Author: Thomas Haller <thaller redhat com>
Date: Mon Oct 27 14:43:59 2014 +0100
c-e: fix passing wrong enum type to gtk_widget_override_background_color()
This had no real effect, because both GTK_STATE_NORMAL
and GTK_STATE_FLAG_NORMAL have the numerical value 0.
clang warns:
make[5]: Entering directory `./network-manager-applet/src/connection-editor'
CC nm_connection_editor-page-ip4.o
page-ip4.c:730:63: error: implicit conversion from enumeration type 'GtkStateType' to different
enumeration type 'GtkStateFlags' [-Werror,-Wenum-conversion]
gtk_widget_override_background_color (GTK_WIDGET (editable), GTK_STATE_NORMAL, &rgba);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~
Signed-off-by: Thomas Haller <thaller redhat com>
src/connection-editor/ip4-routes-dialog.c | 2 +-
src/connection-editor/ip6-routes-dialog.c | 2 +-
src/connection-editor/page-dcb.c | 4 ++--
src/connection-editor/page-ip4.c | 2 +-
src/connection-editor/page-ip6.c | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/src/connection-editor/ip4-routes-dialog.c b/src/connection-editor/ip4-routes-dialog.c
index 494a357..95c1107 100644
--- a/src/connection-editor/ip4-routes-dialog.c
+++ b/src/connection-editor/ip4-routes-dialog.c
@@ -455,7 +455,7 @@ cell_changed_cb (GtkEditable *editable,
colorname = value_valid ? "lightgreen" : "red";
gdk_rgba_parse (&rgba, colorname);
- gtk_widget_override_background_color (GTK_WIDGET (editable), GTK_STATE_NORMAL, &rgba);
+ gtk_widget_override_background_color (GTK_WIDGET (editable), GTK_STATE_FLAG_NORMAL, &rgba);
g_free (cell_text);
return FALSE;
diff --git a/src/connection-editor/ip6-routes-dialog.c b/src/connection-editor/ip6-routes-dialog.c
index 74a7129..c1fef55 100644
--- a/src/connection-editor/ip6-routes-dialog.c
+++ b/src/connection-editor/ip6-routes-dialog.c
@@ -396,7 +396,7 @@ cell_changed_cb (GtkEditable *editable,
colorname = value_valid ? "lightgreen" : "red";
gdk_rgba_parse (&rgba, colorname);
- gtk_widget_override_background_color (GTK_WIDGET (editable), GTK_STATE_NORMAL, &rgba);
+ gtk_widget_override_background_color (GTK_WIDGET (editable), GTK_STATE_FLAG_NORMAL, &rgba);
g_free (cell_text);
return FALSE;
diff --git a/src/connection-editor/page-dcb.c b/src/connection-editor/page-dcb.c
index 241210e..1093f17 100644
--- a/src/connection-editor/page-dcb.c
+++ b/src/connection-editor/page-dcb.c
@@ -125,10 +125,10 @@ uint_entries_validate (GtkBuilder *builder, const char *fmt, gint max, gboolean
if (errno || num < 0 || num > max) {
/* FIXME: only sets highlight color? */
gdk_rgba_parse (&bgcolor, "red3");
- gtk_widget_override_background_color (GTK_WIDGET (entry), GTK_STATE_NORMAL,
&bgcolor);
+ gtk_widget_override_background_color (GTK_WIDGET (entry),
GTK_STATE_FLAG_NORMAL, &bgcolor);
valid = FALSE;
} else
- gtk_widget_override_background_color (GTK_WIDGET (entry), GTK_STATE_NORMAL,
NULL);
+ gtk_widget_override_background_color (GTK_WIDGET (entry),
GTK_STATE_FLAG_NORMAL, NULL);
total += (guint) num;
}
diff --git a/src/connection-editor/page-ip4.c b/src/connection-editor/page-ip4.c
index f47725a..2dbfaa3 100644
--- a/src/connection-editor/page-ip4.c
+++ b/src/connection-editor/page-ip4.c
@@ -727,7 +727,7 @@ cell_changed_cb (GtkEditable *editable,
colorname = value_valid ? "lightgreen" : "red";
gdk_rgba_parse (&rgba, colorname);
- gtk_widget_override_background_color (GTK_WIDGET (editable), GTK_STATE_NORMAL, &rgba);
+ gtk_widget_override_background_color (GTK_WIDGET (editable), GTK_STATE_FLAG_NORMAL, &rgba);
g_free (cell_text);
return FALSE;
diff --git a/src/connection-editor/page-ip6.c b/src/connection-editor/page-ip6.c
index 5340d78..c5d96bc 100644
--- a/src/connection-editor/page-ip6.c
+++ b/src/connection-editor/page-ip6.c
@@ -718,7 +718,7 @@ cell_changed_cb (GtkEditable *editable,
colorname = value_valid ? "lightgreen" : "red";
gdk_rgba_parse (&rgba, colorname);
- gtk_widget_override_background_color (GTK_WIDGET (editable), GTK_STATE_NORMAL, &rgba);
+ gtk_widget_override_background_color (GTK_WIDGET (editable), GTK_STATE_FLAG_NORMAL, &rgba);
g_free (cell_text);
return FALSE;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]