[gdk-pixbuf] lib: Remove incorrect info about area-prepared signal



commit 75ac8deaf04f362efa5fc0ace51031350e70e8be
Author: Bastien Nocera <hadess hadess net>
Date:   Wed Oct 22 15:20:46 2014 +0200

    lib: Remove incorrect info about area-prepared signal
    
    It is not safe to fill the pixbuf returned from area-prepared with a
    background colour as a number of loaders (notably XPM and SVG) will
    only have information about the size and characteristics of the image
    after it's been fully loaded. Filling the background colour would then
    overwrite the image we just loaded.
    
    Given that this won't work properly with anything but 100% transparent
    or 100% solid pixels, remove that advice from the docs. Instead,
    applications should rely on their toolkits to composite over a
    background colour.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=589334

 gdk-pixbuf/gdk-pixbuf-loader.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/gdk-pixbuf/gdk-pixbuf-loader.c b/gdk-pixbuf/gdk-pixbuf-loader.c
index 1835a47..65845ed 100644
--- a/gdk-pixbuf/gdk-pixbuf-loader.c
+++ b/gdk-pixbuf/gdk-pixbuf-loader.c
@@ -62,10 +62,8 @@
  * The second signal, #GdkPixbufLoader::area-prepared, will be emitted as
  * soon as the pixbuf of the desired has been allocated. You can obtain it
  * by calling gdk_pixbuf_loader_get_pixbuf(). If you want to use it, simply
- * ref it.  In addition, no actual information will be passed in yet, so the
- * pixbuf can be safely filled with any temporary graphics (or an initial
- * color) as needed.  You can also call gdk_pixbuf_loader_get_pixbuf() later
- * and get the same pixbuf.
+ * ref it. You can also call gdk_pixbuf_loader_get_pixbuf() later and get
+ * the same pixbuf.
  * 
  * The last signal, #GdkPixbufLoader::area-updated, gets emitted every time
  * a region is updated. This way you can update a partially completed image.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]