[gnome-keyring] gkm-secret-textual: Fix leak in generate_attribute()



commit 165f0e3210e32538c847be91896736c17a1f6ad6
Author: Christophe Fergeau <cfergeau redhat com>
Date:   Wed Oct 1 23:03:00 2014 +0200

    gkm-secret-textual: Fix leak in generate_attribute()
    
    The GList returned by gkm_secret_fields_get_names() must be
    freed with g_list_free after use as this is created using
    g_hash_table_get_keys().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738508

 pkcs11/secret-store/gkm-secret-textual.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/pkcs11/secret-store/gkm-secret-textual.c b/pkcs11/secret-store/gkm-secret-textual.c
index 70a073e..9cda53a 100644
--- a/pkcs11/secret-store/gkm-secret-textual.c
+++ b/pkcs11/secret-store/gkm-secret-textual.c
@@ -118,6 +118,7 @@ generate_attributes (GKeyFile *file, GkmSecretItem *item)
                g_free (groupname);
                ++index;
        }
+       g_list_free (names);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]