[glib/glib-2-42] Add advice on g_cancellable_reset
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/glib-2-42] Add advice on g_cancellable_reset
- Date: Fri, 10 Oct 2014 10:43:42 +0000 (UTC)
commit af0a8911bc3a0d8c7aa30d612be0d7705d147b49
Author: Matthias Clasen <mclasen redhat com>
Date: Mon Oct 6 22:41:06 2014 -0400
Add advice on g_cancellable_reset
Don't use it at home.
gio/gcancellable.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
---
diff --git a/gio/gcancellable.c b/gio/gcancellable.c
index fcfca3f..800e8f3 100644
--- a/gio/gcancellable.c
+++ b/gio/gcancellable.c
@@ -244,6 +244,13 @@ g_cancellable_get_current (void)
*
* If cancellable is currently in use by any cancellable operation
* then the behavior of this function is undefined.
+ *
+ * Note that it is generally not a good idea to reuse an existing
+ * cancellable for more operations after it has been cancelled once,
+ * as this function might tempt you to do. The recommended practice
+ * is to drop the reference to a cancellable after cancelling it,
+ * and let it die with the outstanding async operations. You should
+ * create a fresh cancellable for further async operations.
**/
void
g_cancellable_reset (GCancellable *cancellable)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]