[gimp] app: remove unclear fix from gimp_tool_options_editor_tool_changed()
- From: Michael Natterer <mitch src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] app: remove unclear fix from gimp_tool_options_editor_tool_changed()
- Date: Wed, 8 Oct 2014 22:37:34 +0000 (UTC)
commit 88e8fbce17c477949c30a335e96021b2142dea4e
Author: Michael Natterer <mitch gimp org>
Date: Thu Oct 9 00:33:33 2014 +0200
app: remove unclear fix from gimp_tool_options_editor_tool_changed()
It was introduced in e7ade3f8eca30edb63db4dde075540a3676aea67. The
g_return_if_fail() is IMO useless, the actual fix (which I kept) was
pulling the call to gimp_tool_options_editor_presets_update() inside
the if().
app/widgets/gimptooloptionseditor.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
---
diff --git a/app/widgets/gimptooloptionseditor.c b/app/widgets/gimptooloptionseditor.c
index a4f999a..9d3950a 100644
--- a/app/widgets/gimptooloptionseditor.c
+++ b/app/widgets/gimptooloptionseditor.c
@@ -460,12 +460,6 @@ gimp_tool_options_editor_tool_changed (GimpContext *context,
{
GimpContainer *presets;
GtkWidget *options_gui;
-
- /* This will warn if tool info is changed to nothing.
- * This seems to happen if starting in SWM with tool editor visible
- * Maybe its normal, and the code should just be written to
- * handle this case, but someone smarter needs to take a look*/
- g_return_if_fail(GIMP_IS_TOOL_INFO(tool_info));
if (tool_info && tool_info->tool_options == editor->p->visible_tool_options)
return;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]