[gimp] libgimpwidgets: don't leak the empty_iter in GimpIntStore



commit 7cbb04c0f9e630a7fb569dbce26ef3b5e9262ab1
Author: Michael Natterer <mitch gimp org>
Date:   Mon Oct 6 20:31:51 2014 +0200

    libgimpwidgets: don't leak the empty_iter in GimpIntStore

 libgimpwidgets/gimpintstore.c |   11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)
---
diff --git a/libgimpwidgets/gimpintstore.c b/libgimpwidgets/gimpintstore.c
index 573edfa..6121699 100644
--- a/libgimpwidgets/gimpintstore.c
+++ b/libgimpwidgets/gimpintstore.c
@@ -222,6 +222,8 @@ gimp_int_store_row_inserted (GtkTreeModel *model,
       memcmp (iter, store->empty_iter, sizeof (GtkTreeIter)))
     {
       gtk_list_store_remove (GTK_LIST_STORE (store), store->empty_iter);
+      gtk_tree_iter_free (store->empty_iter);
+      store->empty_iter = NULL;
     }
 }
 
@@ -229,17 +231,8 @@ static void
 gimp_int_store_row_deleted (GtkTreeModel *model,
                             GtkTreePath  *path)
 {
-  GimpIntStore *store = GIMP_INT_STORE (model);
-
   if (parent_iface->row_deleted)
     parent_iface->row_deleted (model, path);
-
-  if (store->empty_iter)
-    {
-      /* freeing here crashes, no clue why. will be freed in finalize() */
-      /* gtk_tree_iter_free (store->empty_iter); */
-      store->empty_iter = NULL;
-    }
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]