[dia] [warningectomy] format string is not a string literal (potentially insecure)
- From: Hans Breuer <hans src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [dia] [warningectomy] format string is not a string literal (potentially insecure)
- Date: Wed, 1 Oct 2014 22:35:23 +0000 (UTC)
commit 3a3c37d49e419fb584cf8f53b4cc511987256180
Author: Hans Breuer <hans breuer org>
Date: Thu Oct 2 00:14:41 2014 +0200
[warningectomy] format string is not a string literal (potentially insecure)
plug-ins.c:234:51: warning: format string is not a string literal (potentially insecure)
[-Wformat-security]
message(_("%s Plugin could not be unloaded"), info->name);
^~~~~~~~~~
lib/plug-ins.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/lib/plug-ins.c b/lib/plug-ins.c
index ce31b18..250ef47 100644
--- a/lib/plug-ins.c
+++ b/lib/plug-ins.c
@@ -231,7 +231,8 @@ dia_plugin_unload(PluginInfo *info)
return;
if (!dia_plugin_can_unload(info)) {
- message(_("%s Plugin could not be unloaded"), info->name);
+ /* calling this function w/o check first is a programmer's error */
+ g_warning ("%s plugin could not be unloaded", info->name);
return;
}
/* perform plugin cleanup */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]