[evolution-data-server/evolution-data-server-3-12] Bug 740627 - [IMAPx] Cannot append to a write-only folder

[Milan Crha <mcrha src gnome org>]

commit 86fb8872d24074c1378e6abfdf2c8d6fb074eca1
Author: Milan Crha <mcrha redhat com>
Date:   Tue Nov 25 17:35:35 2014 +0100

    Bug 740627 - [IMAPx] Cannot append to a write-only folder

 camel/providers/imapx/camel-imapx-server.c |   26 +++++++++++++++++++++++---
 1 files changed, 23 insertions(+), 3 deletions(-)
---
diff --git a/camel/providers/imapx/camel-imapx-server.c b/camel/providers/imapx/camel-imapx-server.c
index ee2be01..4f6f35b 100644
--- a/camel/providers/imapx/camel-imapx-server.c
+++ b/camel/providers/imapx/camel-imapx-server.c
@@ -4004,6 +4004,7 @@ imapx_command_select_done (CamelIMAPXServer *is,
                CamelIMAPXCommandQueue *failed;
                GQueue trash = G_QUEUE_INIT;
                GList *list, *link;
+               gboolean noperm_error;
 
                c (is->tagprefix, "Select failed: %s\n", local_error ? local_error->message : "Unknown 
error");
 
@@ -4020,6 +4021,9 @@ imapx_command_select_done (CamelIMAPXServer *is,
 
                QUEUE_LOCK (is);
 
+               noperm_error = select_pending != NULL && ic->status && ic->status->result == IMAPX_NO &&
+                       (ic->status->condition == IMAPX_NOPERM || ic->status->condition == IMAPX_UNKNOWN);
+
                if (select_pending != NULL) {
                        GList *head = camel_imapx_command_queue_peek_head_link (is->queue);
 
@@ -4043,6 +4047,13 @@ imapx_command_select_done (CamelIMAPXServer *is,
                        }
                }
 
+               if (noperm_error) {
+                       /* This avoids another SELECT try on this mailbox;
+                          the mailbox can be write-only in this case. */
+                       if (camel_imapx_mailbox_get_permanentflags (select_pending) == ~0)
+                               camel_imapx_mailbox_set_permanentflags (select_pending, 0);
+               }
+
                while ((link = g_queue_pop_head (&trash)) != NULL) {
                        CamelIMAPXCommand *cw = link->data;
                        camel_imapx_command_ref (cw);
@@ -4067,7 +4078,8 @@ imapx_command_select_done (CamelIMAPXServer *is,
                                continue;
                        }
 
-                       camel_imapx_job_cancel (failed_job);
+                       if (!noperm_error)
+                               camel_imapx_job_cancel (failed_job);
 
                        if (ic->status)
                                cw->status = imapx_copy_status (ic->status);
@@ -8463,7 +8475,11 @@ camel_imapx_server_copy_message (CamelIMAPXServer *is,
        g_return_val_if_fail (CAMEL_IS_IMAPX_MAILBOX (destination), FALSE);
        g_return_val_if_fail (uids != NULL, FALSE);
 
-       if (!imapx_ensure_mailbox_permanentflags (is, destination, cancellable, error))
+       /* That's okay if the "SELECT" fails here, as it can be due to
+          the folder being write-only; just ignore the error and continue. */
+       imapx_ensure_mailbox_permanentflags (is, destination, cancellable, NULL);
+
+       if (g_cancellable_set_error_if_cancelled (cancellable, error))
                return FALSE;
 
        data = g_slice_new0 (CopyMessagesData);
@@ -8529,7 +8545,11 @@ camel_imapx_server_append_message (CamelIMAPXServer *is,
        g_return_val_if_fail (CAMEL_IS_MIME_MESSAGE (message), FALSE);
        /* CamelMessageInfo can be NULL. */
 
-       if (!imapx_ensure_mailbox_permanentflags (is, mailbox, cancellable, error))
+       /* That's okay if the "SELECT" fails here, as it can be due to
+          the folder being write-only; just ignore the error and continue. */
+       imapx_ensure_mailbox_permanentflags (is, mailbox, cancellable, NULL);
+
+       if (g_cancellable_set_error_if_cancelled (cancellable, error))
                return FALSE;
 
        /* Append just assumes we have no/a dodgy connection.  We dump