[network-manager-applet] editor: fix error handling when requesting secrets from non-existent setting
- From: Dan Williams <dcbw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-applet] editor: fix error handling when requesting secrets from non-existent setting
- Date: Mon, 24 Nov 2014 20:59:51 +0000 (UTC)
commit b4973b85fc03c81e8a0c6c8527b4093124dbf99b
Author: Dan Williams <dcbw redhat com>
Date: Mon Nov 24 14:56:09 2014 -0600
editor: fix error handling when requesting secrets from non-existent setting
When NM core switched over to libnm-core and errors were consolidated,
the error name changed. Recognize the new one. Fixed an issue where
editing any WWAN connection would fail because secrets for the PPP
setting were requested (for GSM username/password) but connections
aren't actually required to have a PPP setting if no user/password
is required.
src/connection-editor/ce-page.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/connection-editor/ce-page.c b/src/connection-editor/ce-page.c
index 001af30..bde329f 100644
--- a/src/connection-editor/ce-page.c
+++ b/src/connection-editor/ce-page.c
@@ -325,6 +325,7 @@ ce_page_complete_init (CEPage *self,
/* Ignore missing settings errors */
if ( error
&& !dbus_g_error_has_name (error, "org.freedesktop.NetworkManager.Settings.InvalidSetting")
+ && !dbus_g_error_has_name (error,
"org.freedesktop.NetworkManager.Settings.Connection.SettingNotFound")
&& !dbus_g_error_has_name (error, "org.freedesktop.NetworkManager.AgentManager.NoSecrets")) {
emit_initialized (self, error);
return;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]