[gnome-shell/gnome-3-12] network: properly remove connections from list

[Dan Williams <dcbw src gnome org>]

commit b7d2191059072cd3e18cb6dc1b31dbff19ef8c8c
Author: Ryan Lortie <desrt desrt ca>
Date:   Sun Nov 16 15:50:14 2014 -0800

    network: properly remove connections from list
    
    Due to a typo we were always removing the first (index 0) connection
    from the global list of connections instead of the correct one.
    
    This resulted in some connections remaining in the shell's connection
    list long after they were removed.  In particular, this resulted in
    multiple copies of a bluetooth connection appearing after suspend/resume
    (when the device was readded and the cached connection list was
    rescanned).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740227
    (cherry picked from commit 3d4408dce810f3b6995ed2acf28b61bed48c1dac)

 js/ui/status/network.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 149b733..1d8453f 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -1816,7 +1816,7 @@ const NMApplet = new Lang.Class({
     _connectionRemoved: function(connection) {
         let pos = this._connections.indexOf(connection);
         if (pos != -1)
-            this._connections.splice(connection, 1);
+            this._connections.splice(pos, 1);
 
         let section = connection._section;