[bugzilla-gnome-org-extensions] weekly bug summary: Use gnome_open_statuses for open bug statuses



commit 0e48bbd8bdb3db58651b6b55e7bf7c409e84e795
Author: Krzesimir Nowak <qdlacz gmail com>
Date:   Wed Nov 19 13:52:15 2014 +0100

    weekly bug summary: Use gnome_open_statuses for open bug statuses
    
    Also, add a dependency on PatchStatus.

 WeeklyBugSummary/Extension.pm |    9 +++++----
 WeeklyBugSummary/lib/Util.pm  |   14 ++++++++------
 2 files changed, 13 insertions(+), 10 deletions(-)
---
diff --git a/WeeklyBugSummary/Extension.pm b/WeeklyBugSummary/Extension.pm
index f63c6bc..dcf0dbf 100644
--- a/WeeklyBugSummary/Extension.pm
+++ b/WeeklyBugSummary/Extension.pm
@@ -14,10 +14,11 @@ sub page_before_template {
 }
 
 sub gnome_deps {
-    'Browse',
-    'DescribeUser',
-    'GnomeAttachmentStatus',
-    'GNOME'
+    ('Browse',
+     'DescribeUser',
+     'GnomeAttachmentStatus',
+     'GNOME',
+     'PatchReport');
 }
 
 __PACKAGE__->NAME;
diff --git a/WeeklyBugSummary/lib/Util.pm b/WeeklyBugSummary/lib/Util.pm
index fd0a89b..b0396ea 100644
--- a/WeeklyBugSummary/lib/Util.pm
+++ b/WeeklyBugSummary/lib/Util.pm
@@ -179,6 +179,12 @@ sub _page_weekly_bug_summary {
     $vars->{'reviewerlist'} = $patchreviewerlist;
 }
 
+sub browse_open_states {
+    my $dbh = Bugzilla->dbh;
+
+    return join(',', map { $dbh->quote($_) } Bugzilla::Status->gnome_open_statuses());
+}
+
 sub get_total_bugs_on_bugzilla {
     my($keyword, $version, $classification_id, $product_id) = @_;
 
@@ -195,9 +201,7 @@ sub get_total_bugs_on_bugzilla {
     }
 
     $query .= "
-      WHERE (bugs.bug_status = 'NEW' OR bugs.bug_status = 'ASSIGNED'
-             OR bugs.bug_status = 'REOPENED'
-             OR bugs.bug_status = 'UNCONFIRMED')";
+      WHERE bugs.bug_status IN (" . browse_open_states() . ")";
 
     if ($keyword) {
         push(@args, lc($keyword));
@@ -357,9 +361,7 @@ sub get_product_bug_lists {
           FROM bugs
     INNER JOIN products
             ON bugs.product_id = products.id
-         WHERE (bugs.bug_status = 'NEW' OR bugs.bug_status = 'ASSIGNED'
-                OR bugs.bug_status = 'REOPENED'
-                OR bugs.bug_status = 'UNCONFIRMED')
+         WHERE bugs.bug_status IN (" . browse_open_states() . ")
            AND bugs.bug_severity != 'enhancement'";
 
     if ($keyword) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]