[bugzilla-gnome-org-extensions] Fix problem with private attachments



commit a9da08c85909ed70a96a09f6fbca54fbefaa7c36
Author: Owen W. Taylor <otaylor fishsoup net>
Date:   Sat Nov 7 18:18:13 2009 -0500

    Fix problem with private attachments
    
    Fix problem where when checking access rights to a private
    attachment an undefined variable $user was being accessed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=601118

 extension/lib/SplinterUtil.pm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/extension/lib/SplinterUtil.pm b/extension/lib/SplinterUtil.pm
index 80c11dd..313f64e 100644
--- a/extension/lib/SplinterUtil.pm
+++ b/extension/lib/SplinterUtil.pm
@@ -36,8 +36,8 @@ sub attachment_is_visible {
 
     return (Bugzilla->user->can_see_bug($attachment->bug->id) &&
             (!$attachment->isprivate ||
-             $user->id == $attachment->attacher->id ||
-             $user->is_insider));
+             Bugzilla->user->id == $attachment->attacher->id ||
+             Bugzilla->user->is_insider));
 }
 
 sub attachment_id_is_patch {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]