[bugzilla-gnome-org-extensions] Remove trace_hash, because we aren't using it.



commit d6f6506b7c4b93bad1d38cad218b90044bf10b14
Author: Max Kanat-Alexander <mkanat everythingsolved com>
Date:   Sat Aug 8 13:15:29 2009 -0500

    Remove trace_hash, because we aren't using it.

 code/db_schema-abstract_schema.pl |    1 -
 lib/TraceParser/Trace.pm          |    6 ------
 2 files changed, 0 insertions(+), 7 deletions(-)
---
diff --git a/code/db_schema-abstract_schema.pl b/code/db_schema-abstract_schema.pl
index 4fe22b4..eabe281 100644
--- a/code/db_schema-abstract_schema.pl
+++ b/code/db_schema-abstract_schema.pl
@@ -36,7 +36,6 @@ $schema->{trace} = {
         type        => {TYPE => 'varchar(255)', NOTNULL => 1},
         short_hash  => {TYPE => 'char(22)'},
         stack_hash  => {TYPE => 'char(22)'},
-        trace_hash  => {TYPE => 'char(22)', NOTNULL => 1},
         trace_text  => {TYPE => 'LONGTEXT', NOTNULL => 1},
         quality     => {TYPE => 'real', NOTNULL => 1},
     ],
diff --git a/lib/TraceParser/Trace.pm b/lib/TraceParser/Trace.pm
index 755c65b..c243bc1 100644
--- a/lib/TraceParser/Trace.pm
+++ b/lib/TraceParser/Trace.pm
@@ -40,7 +40,6 @@ use constant DB_COLUMNS => qw(
     comment_id
     short_hash
     stack_hash
-    trace_hash
     type
     quality
 );
@@ -52,14 +51,12 @@ use constant LIST_ORDER => 'quality DESC, comment_id';
 use constant VALIDATORS => {
     stack_hash  => \&_check_hash,
     short_hash  => \&_check_hash,
-    trace_hash  => \&_check_hash,
     trace_text  => \&_check_thetext,
     type        => \&_check_type,
 };
 
 use constant REQUIRED_CREATE_FIELDS => qw(
     comment_id
-    trace_hash
     trace_text
     type
 );
@@ -167,12 +164,10 @@ sub parse_from_text {
         $short_hash = _hash(join(',', @short_stack));
     }
     my $trace_text = $trace->text;
-    my $trace_hash = _hash($trace_text);
 
     return {
         stack_hash  => $stack_hash,
         short_hash  => $short_hash,
-        trace_hash  => $trace_hash,
         trace_text  => $trace_text,
         type        => ref($trace),
         quality     => $quality,
@@ -205,7 +200,6 @@ sub traces_on_bug {
 sub comment_id  { return $_[0]->{comment_id};  }
 sub stack_hash  { return $_[0]->{stack_hash};  }
 sub short_hash  { return $_[0]->{short_hash};  }
-sub trace_hash  { return $_[0]->{trace_hash};  }
 sub type        { return $_[0]->{type};        }
 sub quality     {
     my $self = shift;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]