[bugzilla-gnome-org-extensions] Implement actual storing of has_symbols.
- From: Krzesimir Nowak <krnowak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [bugzilla-gnome-org-extensions] Implement actual storing of has_symbols.
- Date: Thu, 20 Nov 2014 22:11:34 +0000 (UTC)
commit 3e1724e41ab8e484d1781b5913a65aee0d2a7428
Author: Max Kanat-Alexander <mkanat everythingsolved com>
Date: Thu Jul 30 23:27:08 2009 -0500
Implement actual storing of has_symbols.
lib/TraceParser/Trace.pm | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/lib/TraceParser/Trace.pm b/lib/TraceParser/Trace.pm
index e0aa53a..2ccdfa3 100644
--- a/lib/TraceParser/Trace.pm
+++ b/lib/TraceParser/Trace.pm
@@ -84,15 +84,17 @@ sub parse_from_text {
my @all_functions;
my $quality = 0;
+ my $has_symbols = 1;
my $crash_thread = $trace->thread_with_crash || $trace->threads->[0];
foreach my $frame (@{ $crash_thread->frames }) {
foreach my $item (qw(function args number file line code)) {
$quality++ if defined $frame->$item;
}
my $function = $frame->function;
- if (defined $function && !grep($_ eq $function, IGNORE_FUNCTIONS)) {
+ if (!grep($_ eq $function, IGNORE_FUNCTIONS)) {
push(@all_functions, $frame->function);
}
+ $has_symbols = 0 if $function eq '??';
}
my $max_short_stack = $#all_functions > 4 ? 4 : $#all_functions;
@@ -101,7 +103,7 @@ sub parse_from_text {
my $short_hash = md5_base64(join(',', @short_stack));
return {
- has_symbols => 0, # FIXME
+ has_symbols => $has_symbols,
full_hash => $full_hash,
short_hash => $short_hash,
short_stack => join(', ', @short_stack),
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]