[bugzilla-gnome-org-extensions] browse: Fix whitespace issues
- From: Krzesimir Nowak <krnowak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [bugzilla-gnome-org-extensions] browse: Fix whitespace issues
- Date: Thu, 20 Nov 2014 22:08:40 +0000 (UTC)
commit 82aafe2936f0c9460d83f1292b22e095d86c38e0
Author: Krzesimir Nowak <qdlacz gmail com>
Date: Sun Nov 9 23:31:41 2014 +0100
browse: Fix whitespace issues
Browse/Extension.pm | 3 +-
Browse/lib/Util.pm | 194 ++++++++++----------
.../template/en/default/hook/index-outro.html.tmpl | 2 -
Browse/template/en/default/pages/browse.html.tmpl | 40 ++--
Browse/web/browse.css | 10 +-
Browse/web/browse.js | 13 +-
6 files changed, 129 insertions(+), 133 deletions(-)
---
diff --git a/Browse/Extension.pm b/Browse/Extension.pm
index 295cff5..c22e19c 100644
--- a/Browse/Extension.pm
+++ b/Browse/Extension.pm
@@ -29,12 +29,11 @@ use Bugzilla::Extension::Browse::Util;
our $VERSION = '0.01';
-# See the documentation of Bugzilla::Hook ("perldoc Bugzilla::Hook"
+# See the documentation of Bugzilla::Hook ("perldoc Bugzilla::Hook"
# in the bugzilla directory) for a list of all available hooks.
sub page_before_template {
my ($self, $args) = @_;
page($args);
-
}
__PACKAGE__->NAME;
diff --git a/Browse/lib/Util.pm b/Browse/lib/Util.pm
index cac4b4e..7a318e6 100644
--- a/Browse/lib/Util.pm
+++ b/Browse/lib/Util.pm
@@ -40,13 +40,13 @@ our @EXPORT = qw(
by_severity
by_component
by_assignee
- gnome_target_development
+ gnome_target_development
gnome_target_stable
list_blockers
browse_bug_link
);
-# This file can be loaded by your extension via
+# This file can be loaded by your extension via
# "use Bugzilla::Extension::Browse::Util". You can put functions
# used by your extension in here. (Make sure you also list them in
# @EXPORT.)
@@ -204,25 +204,25 @@ sub _page_browse {
-expires => "Fri, 01-Jan-2038 00:00:00 GMT");
# Create data structures representing each classification
- my @classifications = ();
+ my @classifications = ();
if (scalar @$product_interests) {
- my %watches = (
+ my %watches = (
'name' => 'Watched Products',
'products' => $product_interests
- );
+ );
push @classifications, \%watches;
}
if (Bugzilla->params->{'useclassification'}) {
foreach my $c (@{$user->get_selectable_classifications}) {
# Create hash to hold attributes for each classification.
- my %classification = (
- 'name' => $c->name,
+ my %classification = (
+ 'name' => $c->name,
'products' => [ @{$user->get_selectable_products($c->id)} ]
- );
+ );
# Assign hash back to classification array.
push @classifications, \%classification;
- }
+ }
}
$vars->{'classifications'} = \ classifications;
@@ -268,7 +268,7 @@ sub _page_browse {
# my $format = $template->get_format("browse/main",
# scalar $cgi->param('format'),
# scalar $cgi->param('ctype'));
-#
+#
# print $cgi->header($format->{'ctype'});
# $template->process($format->{'template'}, $vars)
# || ThrowTemplateError($template->error());
@@ -283,9 +283,9 @@ sub total_open_bugs {
my $product = shift;
my $dbh = Bugzilla->dbh;
- return $dbh->selectrow_array("SELECT COUNT(bug_id)
- FROM bugs
- WHERE bug_status IN (" . browse_open_states() . ")
+ return $dbh->selectrow_array("SELECT COUNT(bug_id)
+ FROM bugs
+ WHERE bug_status IN (" . browse_open_states() . ")
AND product_id = ?", undef, $product->id);
}
@@ -298,10 +298,10 @@ sub new_bugs {
my $product = shift;
my $dbh = Bugzilla->dbh;
- return $dbh->selectrow_array("SELECT COUNT(bug_id)
- FROM bugs
- WHERE bug_status IN (" . browse_open_states() . ")
- AND creation_ts >= " . $dbh->sql_date_math('LOCALTIMESTAMP(0)',
'-', 7, 'DAY') . "
+ return $dbh->selectrow_array("SELECT COUNT(bug_id)
+ FROM bugs
+ WHERE bug_status IN (" . browse_open_states() . ")
+ AND creation_ts >= " . $dbh->sql_date_math('LOCALTIMESTAMP(0)',
'-', 7, 'DAY') . "
AND product_id = ?", undef, $product->id);
}
@@ -310,13 +310,13 @@ sub new_patches {
my $dbh = Bugzilla->dbh;
return $dbh->bz_column_info('attachments', 'status') ?
- $dbh->selectrow_array("SELECT COUNT(attach_id)
- FROM bugs, attachments
+ $dbh->selectrow_array("SELECT COUNT(attach_id)
+ FROM bugs, attachments
WHERE bugs.bug_id = attachments.bug_id
- AND bug_status IN (" . browse_open_states() . ")
+ AND bug_status IN (" . browse_open_states() . ")
AND attachments.ispatch = 1 AND attachments.isobsolete = 0
- AND attachments.status = 'none'
- AND attachments.creation_ts >= " .
$dbh->sql_date_math('LOCALTIMESTAMP(0)', '-', 7, 'DAY') . "
+ AND attachments.status = 'none'
+ AND attachments.creation_ts >= " .
$dbh->sql_date_math('LOCALTIMESTAMP(0)', '-', 7, 'DAY') . "
AND product_id = ?", undef, $product->id) :
"?";
}
@@ -325,11 +325,11 @@ sub keyword_bugs {
my ($product, $keyword) = @_;
my $dbh = Bugzilla->dbh;
- return $dbh->selectrow_array("SELECT COUNT(bugs.bug_id)
- FROM bugs, keywords
- WHERE bugs.bug_id = keywords.bug_id
- AND bug_status IN (" . browse_open_states() . ")
- AND keywords.keywordid = ?
+ return $dbh->selectrow_array("SELECT COUNT(bugs.bug_id)
+ FROM bugs, keywords
+ WHERE bugs.bug_id = keywords.bug_id
+ AND bug_status IN (" . browse_open_states() . ")
+ AND keywords.keywordid = ?
AND product_id = ?", undef, ($keyword->id, $product->id));
}
@@ -340,12 +340,12 @@ sub no_response_bugs {
if (@developer_ids) {
return $dbh->selectcol_arrayref("SELECT bugs.bug_id
- FROM bugs INNER JOIN longdescs ON longdescs.bug_id = bugs.bug_id
- WHERE bug_status IN (" . browse_open_states() . ")
- AND bug_severity != 'enhancement'
- AND product_id = ?
- AND bugs.reporter NOT IN (" . join(",", @developer_ids) . ")
- GROUP BY bugs.bug_id
+ FROM bugs INNER JOIN longdescs ON longdescs.bug_id = bugs.bug_id
+ WHERE bug_status IN (" . browse_open_states() . ")
+ AND bug_severity != 'enhancement'
+ AND product_id = ?
+ AND bugs.reporter NOT IN (" . join(",", @developer_ids) . ")
+ GROUP BY bugs.bug_id
HAVING COUNT(distinct longdescs.who) = 1", undef, $product->id);
}
else {
@@ -356,24 +356,24 @@ sub no_response_bugs {
sub critical_warning_bugs {
my $product = shift;
my $dbh = Bugzilla->dbh;
-
- return $dbh->selectrow_array("SELECT COUNT(bugs.bug_id)
+
+ return $dbh->selectrow_array("SELECT COUNT(bugs.bug_id)
FROM bugs INNER JOIN bugs_fulltext ON bugs_fulltext.bug_id = bugs.bug_id
- WHERE bug_status IN (" . browse_open_states() . ")
- AND " .
$dbh->sql_fulltext_search("bugs_fulltext.comments_noprivate", "'+G_LOG_LEVEL_CRITICAL'") . "
+ WHERE bug_status IN (" . browse_open_states() . ")
+ AND " .
$dbh->sql_fulltext_search("bugs_fulltext.comments_noprivate", "'+G_LOG_LEVEL_CRITICAL'") . "
AND product_id = ?", undef, $product->id);
}
sub string_bugs {
my $product = shift;
my $dbh = Bugzilla->dbh;
-
- return $dbh->selectrow_array("SELECT COUNT(bugs.bug_id)
- FROM bugs, keywords, keyworddefs
- WHERE bugs.bug_id = keywords.bug_id
- AND keywords.keywordid = keyworddefs.id
- AND keyworddefs.name = 'string'
- AND bug_status IN (" . browse_open_states() . ")
+
+ return $dbh->selectrow_array("SELECT COUNT(bugs.bug_id)
+ FROM bugs, keywords, keyworddefs
+ WHERE bugs.bug_id = keywords.bug_id
+ AND keywords.keywordid = keyworddefs.id
+ AND keyworddefs.name = 'string'
+ AND bug_status IN (" . browse_open_states() . ")
AND product_id = ?", undef, $product->id);
}
@@ -382,14 +382,14 @@ sub by_patch_status {
my $dbh = Bugzilla->dbh;
return $dbh->bz_column_info('attachments', 'status') ?
- $dbh->selectall_arrayref("SELECT attachments.status, COUNT(attach_id)
+ $dbh->selectall_arrayref("SELECT attachments.status, COUNT(attach_id)
FROM bugs, attachments
- WHERE attachments.bug_id = bugs.bug_id
- AND bug_status IN (" . browse_open_states() . ")
- AND product_id = ?
- AND attachments.ispatch = 1
- AND attachments.isobsolete != 1
- AND attachments.status IN (" . join(",", map { $dbh->quote($_) }
IMPORTANT_PATCH_STATUSES) . ")
+ WHERE attachments.bug_id = bugs.bug_id
+ AND bug_status IN (" . browse_open_states() . ")
+ AND product_id = ?
+ AND attachments.ispatch = 1
+ AND attachments.isobsolete != 1
+ AND attachments.status IN (" . join(",", map { $dbh->quote($_) }
IMPORTANT_PATCH_STATUSES) . ")
GROUP BY attachments.status", undef, $product->id) :
"?";
}
@@ -405,13 +405,13 @@ sub by_version {
my $product = shift;
my $dbh = Bugzilla->dbh;
- my @result = sort { vers_cmp($a->[0], $b->[0]) }
- @{$dbh->selectall_arrayref("SELECT version, COUNT(bug_id)
- FROM bugs
- WHERE bug_status IN (" . browse_open_states() . ")
- AND product_id = ?
+ my @result = sort { vers_cmp($a->[0], $b->[0]) }
+ @{$dbh->selectall_arrayref("SELECT version, COUNT(bug_id)
+ FROM bugs
+ WHERE bug_status IN (" . browse_open_states() . ")
+ AND product_id = ?
GROUP BY version", undef, $product->id)};
-
+
return \ result;
}
@@ -431,10 +431,10 @@ sub needinfo_split {
WHEN delta_ts < '$ni_a' THEN 'B'
ELSE 'A' END";
- my %results = @{$dbh->selectcol_arrayref("SELECT $needinfo_case age, COUNT(bug_id)
- FROM bugs
- WHERE bug_status = 'NEEDINFO'
- AND product_id = ?
+ my %results = @{$dbh->selectcol_arrayref("SELECT $needinfo_case age, COUNT(bug_id)
+ FROM bugs
+ WHERE bug_status = 'NEEDINFO'
+ AND product_id = ?
GROUP BY $needinfo_case", { Columns=>[1,2] }, $product->id)};
return \%results;
}
@@ -443,14 +443,14 @@ sub by_target {
my $product = shift;
my $dbh = Bugzilla->dbh;
- my @result = sort { vers_cmp($a->[0], $b->[0]) }
- @{$dbh->selectall_arrayref("SELECT target_milestone, COUNT(bug_id)
- FROM bugs
- WHERE bug_status IN (" . browse_open_states() . ")
- AND target_milestone != '---'
- AND product_id = ?
+ my @result = sort { vers_cmp($a->[0], $b->[0]) }
+ @{$dbh->selectall_arrayref("SELECT target_milestone, COUNT(bug_id)
+ FROM bugs
+ WHERE bug_status IN (" . browse_open_states() . ")
+ AND target_milestone != '---'
+ AND product_id = ?
GROUP BY target_milestone", undef, $product->id)};
-
+
return \ result;
}
@@ -460,12 +460,12 @@ sub by_priority {
my $i = 0;
my %order_priority = map { $_ => $i++ } @{get_legal_field_values('priority')};
-
- my @result = sort { $order_priority{$a->[0]} <=> $order_priority{$b->[0]} }
- @{$dbh->selectall_arrayref("SELECT priority, COUNT(bug_id)
- FROM bugs
- WHERE bug_status IN (" . browse_open_states() . ")
- AND product_id = ?
+
+ my @result = sort { $order_priority{$a->[0]} <=> $order_priority{$b->[0]} }
+ @{$dbh->selectall_arrayref("SELECT priority, COUNT(bug_id)
+ FROM bugs
+ WHERE bug_status IN (" . browse_open_states() . ")
+ AND product_id = ?
GROUP BY priority", undef, $product->id)};
return \ result;
@@ -478,11 +478,11 @@ sub by_severity {
my $i = 0;
my %order_severity = map { $_ => $i++ } @{get_legal_field_values('bug_severity')};
- my @result = sort { $order_severity{$a->[0]} <=> $order_severity{$b->[0]} }
- @{$dbh->selectall_arrayref("SELECT bug_severity, COUNT(bug_id)
- FROM bugs
- WHERE bug_status IN (" . browse_open_states() . ")
- AND product_id = ?
+ my @result = sort { $order_severity{$a->[0]} <=> $order_severity{$b->[0]} }
+ @{$dbh->selectall_arrayref("SELECT bug_severity, COUNT(bug_id)
+ FROM bugs
+ WHERE bug_status IN (" . browse_open_states() . ")
+ AND product_id = ?
GROUP BY bug_severity", undef, $product->id)};
return \ result;
@@ -492,10 +492,10 @@ sub by_component {
my $product = shift;
my $dbh = Bugzilla->dbh;
- return $dbh->selectall_arrayref("SELECT components.name, COUNT(bugs.bug_id)
- FROM bugs INNER JOIN components ON bugs.component_id = components.id
- WHERE bug_status IN (" . browse_open_states() . ")
- AND bugs.product_id = ?
+ return $dbh->selectall_arrayref("SELECT components.name, COUNT(bugs.bug_id)
+ FROM bugs INNER JOIN components ON bugs.component_id = components.id
+ WHERE bug_status IN (" . browse_open_states() . ")
+ AND bugs.product_id = ?
GROUP BY components.name", undef, $product->id);
}
@@ -503,17 +503,17 @@ sub by_assignee {
my $product = shift;
my $dbh = Bugzilla->dbh;
- my @result = map { Bugzilla::User->new($_) }
- @{$dbh->selectall_arrayref("SELECT bugs.assignee AS userid, COUNT(bugs.bug_id)
- FROM bugs
- WHERE bug_status IN (" . browse_open_states() . ")
- AND bugs.product_id = ?
+ my @result = map { Bugzilla::User->new($_) }
+ @{$dbh->selectall_arrayref("SELECT bugs.assignee AS userid, COUNT(bugs.bug_id)
+ FROM bugs
+ WHERE bug_status IN (" . browse_open_states() . ")
+ AND bugs.product_id = ?
GROUP BY components.name", undef, $product->id)};
-
+
return \ result;
}
-sub gnome_target_development {
+sub gnome_target_development {
my @legal_gnome_target = @{get_legal_field_values('cf_gnome_target')};
return $legal_gnome_target[(scalar @legal_gnome_target) -1];
}
@@ -527,12 +527,12 @@ sub list_blockers {
my $product = shift;
my $dbh = Bugzilla->dbh;
- my $sth = $dbh->prepare("SELECT bugs.bug_id, products.name AS product, bugs.bug_status,
- bugs.resolution, bugs.bug_severity, bugs.short_desc
+ my $sth = $dbh->prepare("SELECT bugs.bug_id, products.name AS product, bugs.bug_status,
+ bugs.resolution, bugs.bug_severity, bugs.short_desc
FROM bugs INNER JOIN products ON bugs.product_id = products.id
- WHERE product_id = ?
- AND bugs.cf_gnome_target = ?
- AND bug_status IN (" . browse_open_states() . ")
+ WHERE product_id = ?
+ AND bugs.cf_gnome_target = ?
+ AND bug_status IN (" . browse_open_states() . ")
ORDER BY bug_id DESC");
my @list_blockers_development;
@@ -540,13 +540,13 @@ sub list_blockers {
while (my $bug = $sth->fetchrow_hashref) {
push(@list_blockers_development, $bug);
}
-
+
my @list_blockers_stable;
$sth->execute($product->id, gnome_target_stable());
while (my $bug = $sth->fetchrow_hashref) {
push(@list_blockers_stable, $bug);
}
-
+
return (\ list_blockers_stable, \ list_blockers_development);
}
diff --git a/Browse/template/en/default/hook/index-outro.html.tmpl
b/Browse/template/en/default/hook/index-outro.html.tmpl
index 30f0a4d..9a9963a 100644
--- a/Browse/template/en/default/hook/index-outro.html.tmpl
+++ b/Browse/template/en/default/hook/index-outro.html.tmpl
@@ -1,4 +1,3 @@
-
[% IF user.product_interests.size > 0 %]
<h3>Interested products</h3>
@@ -9,4 +8,3 @@
[% END %]
</ul>
[% END %]
-
diff --git a/Browse/template/en/default/pages/browse.html.tmpl
b/Browse/template/en/default/pages/browse.html.tmpl
index 31bf09e..d5172bf 100644
--- a/Browse/template/en/default/pages/browse.html.tmpl
+++ b/Browse/template/en/default/pages/browse.html.tmpl
@@ -48,7 +48,7 @@
</tr>
<tr>
- <td>New [% terms.Bugs %]</td>
+ <td>New [% terms.Bugs %]</td>
<td align="right"><a href="[% buglink FILTER html %]&chfield=[% "[Bug creation]" FILTER uri
%]&chfieldfrom=[% what_new_means FILTER html %]">
[% new_bugs FILTER html %]</a></li></td>
</tr>
@@ -64,8 +64,8 @@
<tr>
<td>
- <a class="boogle_edit"
- href="javascript:addText('keywords:gnome-love')">GNOME-love
+ <a class="boogle_edit"
+ href="javascript:addText('keywords:gnome-love')">GNOME-love
[%= terms.bugs %]</a>
</td>
<td align="right">
@@ -97,8 +97,8 @@
%]
<tr>
<td>
- <em><a class="boogle_edit"
- href="javascript:addText('+G_LOG_LEVEL_CRITICAL')">Critical
+ <em><a class="boogle_edit"
+ href="javascript:addText('+G_LOG_LEVEL_CRITICAL')">Critical
warning [% terms.bugs %]</a></em>
</td>
<td align="right">
@@ -106,7 +106,7 @@
[%- critical_warning_bugs FILTER html %]</a></em>
</td>
</tr>
- <!--
+ <!--
<tr>
<td><a class="boogle_edit" href="javascript:addText('keyword:string')">String [% terms.bugs %]</a></td>
<td align="right"><a href="[% buglink FILTER html %]&keywords=string">[% string_bugs FILTER html
%]</a></td>
@@ -117,7 +117,7 @@
######################################################################
%]
</table>
-
+
[% IF by_patch_status.size %]
<h3>Patch Status</h3>
<table border="0" cellpadding="0" cellspacing="0" class="figures">
@@ -125,7 +125,7 @@
<tr>
<td>
<!--
- <a class="boogle_edit"
+ <a class="boogle_edit"
href="javascript:addText('patch-status:[% col.0 FILTER js %]')"> -->
[% col.0 FILTER html %] <!-- </a> -->
[% IF col.0 == 'none' %] (unreviewed)[% END %]
@@ -139,14 +139,14 @@
[% END %]
</table>
[% END %]
-
+
[% IF by_priority.size %]
<h3>Priority</h3>
<table border="0" cellpadding="0" cellspacing="0" class="figures">
[% FOREACH col = by_priority %]
<tr>
<td>
- <a class="boogle_edit"
+ <a class="boogle_edit"
href="javascript:addText('priority:[% col.0 FILTER js %]')">
[%- col.0 FILTER html %]</a>
</td>
@@ -158,14 +158,14 @@
[% END %]
</table>
[% END %]
-
+
[% IF by_severity.size %]
<h3>Severity</h3>
<table border="0" cellpadding="0" cellspacing="0" class="figures">
[% FOREACH col = by_severity %]
<tr>
<td>
- <a class="boogle_edit"
+ <a class="boogle_edit"
href="javascript:addText('severity:[% col.0 FILTER js %]')">
[%- col.0 FILTER html %]</a>
</td>
@@ -177,7 +177,7 @@
[% END %]
</table>
[% END %]
-
+
<h3>Useful links</h3>
<ul>
<li>
@@ -199,10 +199,10 @@
<li>
<!--
<a href="simple-bug-guide.cgi?product=
- [%- product.name FILTER uri %]">File a
+ [%- product.name FILTER uri %]">File a
[%= terms.bug %]</a> -->
<a href="enter_bug.cgi?product=
- [%- product.name FILTER uri %]">File a
+ [%- product.name FILTER uri %]">File a
[%= terms.bug %]</a>
</li>
[% END %]
@@ -246,7 +246,7 @@ Browse:
[% FOREACH c = classifications %]
<optgroup label="[% c.name FILTER html %]">
[% FOREACH p = c.products %]
- <option value="[% p.name FILTER html %]"
+ <option value="[% p.name FILTER html %]"
[% IF p.name == product.name && seen != 1 %]selected="selected"[% seen = 1 %]
[% END %]>
[% p.name FILTER html %]</option>
@@ -259,16 +259,16 @@ Browse:
<p><i>[% product.description FILTER none %]</i></p>
-[% PROCESS gnomeblocker list = blockers_development
+[% PROCESS gnomeblocker list = blockers_development
target = target_development %]
[% PROCESS gnomeblocker list = blockers_stable
target = target_stable %]
-<form class="boogleform" id="boogle_search" action="buglist.cgi"
+<form class="boogleform" id="boogle_search" action="buglist.cgi"
method="get">
<div>
<p>Search for [% terms.bugs %] in [% product.name FILTER html %]: <br />
- <input id="boogle_search_box" name="quicksearch" type="text"
+ <input id="boogle_search_box" name="quicksearch" type="text"
value="product:"[% product.name.replace('\\[', '\[').replace('\\]', '\]').replace(':','\:')
FILTER none %]" "
size="50">
<input id="show" type="submit" value="Show">
@@ -442,7 +442,7 @@ Browse:
<table border="0" class="gnomeblocker" cellpadding="0" cellspacing="0">
<thead>
<tr>
- <td colspan="5">Blocker [% terms.bugs %]:
+ <td colspan="5">Blocker [% terms.bugs %]:
<b> <a class="boogle_edit"
href="javascript:addText('cf_gnome_target:
[%- target FILTER js %]')">
diff --git a/Browse/web/browse.css b/Browse/web/browse.css
index 693b2cc..3d7322d 100644
--- a/Browse/web/browse.css
+++ b/Browse/web/browse.css
@@ -1,14 +1,14 @@
#product_summary {
- float: right;
+ float: right;
-moz-border-radius-topleft: 20px;
- -moz-border-radius-bottomleft: 20px;
+ -moz-border-radius-bottomleft: 20px;
margin: 0;
- background-color: #ffeafd;
- padding: 0 1em 1em 1em;
+ background-color: #ffeafd;
+ padding: 0 1em 1em 1em;
}
#product_summary h3 {
- padding: 1em 0 0 0;
+ padding: 1em 0 0 0;
}
#product_summary ul {
diff --git a/Browse/web/browse.js b/Browse/web/browse.js
index 8d47a38..ea1b7ac 100644
--- a/Browse/web/browse.js
+++ b/Browse/web/browse.js
@@ -19,7 +19,7 @@ function addText(text) {
if (colonloc != -1)
querytype = text.substring(0,colonloc);
- else {
+ else {
/* comment or +critical_warning */
var oldvalue = searchBox.value;
var location = oldvalue.indexOf(text);
@@ -62,14 +62,14 @@ function addText(text) {
if (oldvalue.search(value) == -1) {
/* prepend the new value */
- searchBox.value = oldvalue.substring(0,location) + text + ","
+ searchBox.value = oldvalue.substring(0,location) + text + ","
+ oldvalue.substring(location + querytype.length + 1);
} else {
/* value is already in list, remove it */
var vlocation = oldvalue.indexOf(value);
-
+
/* how many values are there for the current querytype? */
var queryvalues = oldvalue.substring(location + querytype.length + 1);
if (queryvalues.indexOf(":") >= 0) {
@@ -91,14 +91,14 @@ function addText(text) {
} else {
/* only remove one value */
- /* last of all value in querytype?
+ /* last of all value in querytype?
then do not remove the trailing but the preceding character */
if ( (vlocation + value.length == oldvalue.length) /*last in string? */
||
(oldvalue.substring(vlocation + value.length, /*trailing space? */
- vlocation + value.length + 1) == ' ')
- )
+ vlocation + value.length + 1) == ' ')
+ )
{
searchBox.value = oldvalue.substring(0,vlocation-1)
+ oldvalue.substring(vlocation + value.length);
@@ -113,4 +113,3 @@ function addText(text) {
} /* if (location == -1) */
}
-
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
