[bugzilla-gnome-org-extensions] developers: Fix some style issues



commit 17feed1ccb798d3de347d7a7e7168aeeb92b2952
Author: Krzesimir Nowak <qdlacz gmail com>
Date:   Sat Nov 8 19:05:34 2014 +0100

    developers: Fix some style issues

 Developers/lib/Ops.pm     |    6 +++---
 Developers/lib/Product.pm |    6 +++---
 Developers/lib/User.pm    |    2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)
---
diff --git a/Developers/lib/Ops.pm b/Developers/lib/Ops.pm
index 9038b23..624afb1 100644
--- a/Developers/lib/Ops.pm
+++ b/Developers/lib/Ops.pm
@@ -75,7 +75,7 @@ sub _create_developer {
     # made a member of the global developers group
     my $dev_group = Bugzilla::Group->new({ name => dev() });
 
-    if (!$dev_group) {
+    unless ($dev_group) {
         $dev_group = Bugzilla::Group->create({
             name        => dev(),
             description => Dev(),
@@ -109,7 +109,7 @@ sub migrate_gnome_developers {
         my $group = Bugzilla::Group->new(
             { name => dev_group_name($product) });
 
-        if (!$group) {
+        unless ($group) {
             _create_developer($product);
         }
     }
@@ -170,7 +170,7 @@ sub maybe_rename_developers_group {
     my ($object, $old_object, $changes) = @_;
 
     if ($object->isa(b_p())) {
-        if (defined $changes->{'name'}) {
+        if (defined ($changes->{'name'})) {
             _rename_developer($object, $old_object, $changes);
         }
     }
diff --git a/Developers/lib/Product.pm b/Developers/lib/Product.pm
index 418b3d3..9f88492 100644
--- a/Developers/lib/Product.pm
+++ b/Developers/lib/Product.pm
@@ -9,8 +9,8 @@ use Bugzilla::Extension::Developers::Util;
 sub developers {
     my ($self) = @_;
 
-    if (!defined $self->{dev()}) {
-        my $group = Bugzilla::Group->new({ name => dev_group_name($self) });
+    unless (defined ($self->{dev()})) {
+        my $group = Bugzilla::Group->new({ 'name' => dev_group_name($self) });
 
         $self->{dev()} = $group ? $group->members_non_inherited : [];
     }
@@ -19,7 +19,7 @@ sub developers {
 }
 
 BEGIN {
-        *Bugzilla::Product::developers = \&developers;
+    *Bugzilla::Product::developers = \&developers;
 }
 
 1;
diff --git a/Developers/lib/User.pm b/Developers/lib/User.pm
index 25fa379..c49d6d9 100644
--- a/Developers/lib/User.pm
+++ b/Developers/lib/User.pm
@@ -19,7 +19,7 @@ sub is_developer {
 }
 
 BEGIN {
-        *Bugzilla::User::is_developer = \&is_developer;
+    *Bugzilla::User::is_developer = \&is_developer;
 }
 
 1;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]