[gnome-maps/wip/templates: 16/16] Sidebar: remove unnecessary parameters



commit c893293b70ecc4bb97aeda5f729b876d3460d4fd
Author: Mattias Bengtsson <mattias jc bengtsson gmail com>
Date:   Thu Nov 20 16:28:58 2014 +0100

    Sidebar: remove unnecessary parameters
    
    No need to let _initTransportationToggles have these as parameters since
    they are already fields in the class now.

 src/sidebar.js |   21 +++++++++++----------
 1 files changed, 11 insertions(+), 10 deletions(-)
---
diff --git a/src/sidebar.js b/src/sidebar.js
index 26ac719..5db8e07 100644
--- a/src/sidebar.js
+++ b/src/sidebar.js
@@ -77,9 +77,7 @@ const Sidebar = new Lang.Class({
         this._mapView = mapView;
 
         this._initInstructionList();
-        this._initTransportationToggles(this._modePedestrianToggle,
-                                        this._modeBikeToggle,
-                                        this._modeCarToggle);
+        this._initTransportationToggles();
 
         let query = Application.routeService.query;
 
@@ -100,7 +98,7 @@ const Sidebar = new Lang.Class({
         }).bind(this));
     },
 
-    _initTransportationToggles: function(pedestrian, bike, car) {
+    _initTransportationToggles: function() {
         let query = Application.routeService.query;
         let transport = RouteQuery.Transportation;
 
@@ -108,20 +106,23 @@ const Sidebar = new Lang.Class({
             if (button.active && query.transportation !== mode)
                 query.transportation = mode;
         };
-        pedestrian.connect('toggled', onToggle.bind(this, transport.PEDESTRIAN));
-        car.connect('toggled', onToggle.bind(this, transport.CAR));
-        bike.connect('toggled', onToggle.bind(this, transport.BIKE));
+        this._modePedestrianToggle.connect('toggled',
+                                           onToggle.bind(this, transport.PEDESTRIAN));
+        this._modeCarToggle.connect('toggled',
+                                    onToggle.bind(this, transport.CAR));
+        this._modeBikeToggle.connect('toggled',
+                                     onToggle.bind(this, transport.BIKE));
 
         let setToggles = function() {
             switch(query.transportation) {
             case transport.PEDESTRIAN:
-                pedestrian.active = true;
+                this._modePedestrianToggle.active = true;
                 break;
             case transport.CAR:
-                car.active = true;
+                this._modeCarToggle.active = true;
                 break;
             case transport.BIKE:
-                bike.active = true;
+                this._modeBikeToggle.active = true;
                 break;
             }
         };


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]