[evolution-data-server] [ECalBackendFile] Stops refresh thread too late



commit 03a0dfb339e4cb4bc1f123a253de132d2bd414c9
Author: Milan Crha <mcrha redhat com>
Date:   Fri Nov 14 13:38:14 2014 +0100

    [ECalBackendFile] Stops refresh thread too late
    
    This had been done in backend's finalize, but the function uses
    backend's ESource, which is gone during finalize. That produced
    runtime warnings. The refresh thread should be stopped in dispose.

 calendar/backends/file/e-cal-backend-file.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/calendar/backends/file/e-cal-backend-file.c b/calendar/backends/file/e-cal-backend-file.c
index 0619820..b7479ee 100644
--- a/calendar/backends/file/e-cal-backend-file.c
+++ b/calendar/backends/file/e-cal-backend-file.c
@@ -319,6 +319,8 @@ e_cal_backend_file_dispose (GObject *object)
        cbfile = E_CAL_BACKEND_FILE (object);
        priv = cbfile->priv;
 
+       free_refresh_data (E_CAL_BACKEND_FILE (object));
+
        /* Save if necessary */
        if (priv->is_dirty)
                save_file_when_idle (cbfile);
@@ -346,8 +348,6 @@ e_cal_backend_file_finalize (GObject *object)
        if (priv->dirty_idle_id)
                g_source_remove (priv->dirty_idle_id);
 
-       free_refresh_data (E_CAL_BACKEND_FILE (object));
-
        g_mutex_clear (&priv->refresh_lock);
 
        g_rec_mutex_clear (&priv->idle_save_rmutex);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]