[geary] Don't assert Message-ID was decoded for non-empty string: Bug #740049



commit 9cb7e6bd1307c71f2ea60f1767f177ef281fa868
Author: Jim Nelson <jim yorba org>
Date:   Thu Nov 13 19:35:04 2014 -0800

    Don't assert Message-ID was decoded for non-empty string: Bug #740049
    
    If Message-ID string is "<>", then no Message-ID will be decoded even
    though the string itself is non-empty.

 src/engine/rfc822/rfc822-message-data.vala |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/engine/rfc822/rfc822-message-data.vala b/src/engine/rfc822/rfc822-message-data.vala
index fa0bb5a..59def0f 100644
--- a/src/engine/rfc822/rfc822-message-data.vala
+++ b/src/engine/rfc822/rfc822-message-data.vala
@@ -139,8 +139,8 @@ public class Geary.RFC822.MessageIDList : Geary.MessageData.AbstractMessageData,
         if (!String.is_empty(canonicalized.str))
             list.add(new MessageID(canonicalized.str));
         
-        if (!String.is_empty(value))
-            assert(list.size > 0);
+        // don't assert that list.size > 0; even though this method should generated a decoded ID
+        // from any non-empty string, an empty Message-ID (i.e. "<>") won't.
     }
     
     public override string to_string() {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]