[easytag] Allow the tag area image treeview to expand



commit 7d2e5f3f1a1a72f9cccad38583480a7f4d1116dc
Author: David King <amigadave amigadave com>
Date:   Fri Nov 7 19:02:15 2014 +0000

    Allow the tag area image treeview to expand
    
    Repack the tag area and file are into a GtkGrid rather than a GtkBox,
    and allow the images treeview to expand, so that the tag area expands
    vertically if there is room.
    
    https://mail.gnome.org/archives/easytag-list/2014-November/msg00005.html

 data/tag_area.ui         |    4 ++--
 src/application_window.c |   13 ++++++++-----
 2 files changed, 10 insertions(+), 7 deletions(-)
---
diff --git a/data/tag_area.ui b/data/tag_area.ui
index 73cd5fd..883536f 100644
--- a/data/tag_area.ui
+++ b/data/tag_area.ui
@@ -296,7 +296,7 @@
                         <property name="has-entry">True</property>
                         <property name="model">track_combo_model</property>
                         <property name="entry-text-column">0</property>
-                        <property name="expand">True</property>
+                        <property name="hexpand">True</property>
                         <property name="visible">True</property>
                         <property name="wrap-width">3</property>
                     </object>
@@ -514,12 +514,12 @@
                 <property name="visible">True</property>
                 <child>
                     <object class="GtkScrolledWindow" id="images_scrolled">
-                        <property name="expand">True</property>
                         <property name="shadow-type">etched-in</property>
                         <property name="tooltip-text" translatable="yes">You can use drag and drop to add an 
image</property>
                         <property name="visible">True</property>
                         <child>
                             <object class="GtkTreeView" id="images_view">
+                                <property name="expand">True</property>
                                 <property name="model">images_model</property>
                                 <property name="headers-visible">False</property>
                                 <property name="visible">True</property>
diff --git a/src/application_window.c b/src/application_window.c
index 483edf6..2889853 100644
--- a/src/application_window.c
+++ b/src/application_window.c
@@ -1608,7 +1608,8 @@ et_application_window_init (EtApplicationWindow *self)
     GAction *action;
     GtkWindow *window;
     GtkWidget *main_vbox;
-    GtkWidget *hbox, *vbox;
+    GtkWidget *hbox;
+    GtkWidget *grid;
 
     priv = self->priv = G_TYPE_INSTANCE_GET_PRIVATE (self,
                                                      ET_TYPE_APPLICATION_WINDOW,
@@ -1695,19 +1696,21 @@ et_application_window_init (EtApplicationWindow *self)
     gtk_paned_pack1 (GTK_PANED (priv->hpaned), priv->browser, TRUE, TRUE);
 
     /* Vertical box for FileArea + TagArea */
-    vbox = gtk_box_new (GTK_ORIENTATION_VERTICAL, 0);
-    gtk_paned_pack2 (GTK_PANED (priv->hpaned), vbox, FALSE, FALSE);
+    grid = gtk_grid_new ();
+    gtk_orientable_set_orientation (GTK_ORIENTABLE (grid),
+                                    GTK_ORIENTATION_VERTICAL);
+    gtk_paned_pack2 (GTK_PANED (priv->hpaned), grid, FALSE, FALSE);
 
     /* TODO: Set a sensible default size for both widgets in the paned. */
     gtk_paned_set_position (GTK_PANED (priv->hpaned), 600);
 
     /* File */
     priv->file_area = et_file_area_new ();
-    gtk_box_pack_start (GTK_BOX (vbox), priv->file_area, FALSE, FALSE, 0);
+    gtk_container_add (GTK_CONTAINER (grid), priv->file_area);
 
     /* Tag */
     priv->tag_area = et_tag_area_new ();
-    gtk_box_pack_start (GTK_BOX (vbox), priv->tag_area, FALSE, FALSE, 0);
+    gtk_container_add (GTK_CONTAINER (grid), priv->tag_area);
 
     /* Vertical pane for Browser Area + FileArea + TagArea */
     priv->vpaned = gtk_paned_new (GTK_ORIENTATION_VERTICAL);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]