[easytag] Fix process-fields setting handling in scanner

[David King <davidk src gnome org>]

commit 871ec1c8c2e0f08a665c881c09548314d0fc5ade
Author: David King <amigadave amigadave com>
Date:   Fri Nov 7 08:39:45 2014 +0000

    Fix process-fields setting handling in scanner
    
    Connect solely to the GSettings changed signal, rather than also
    connecting to the toggled signal on the check buttons. This ensures that
    the state is updated only when the GSettings key changes, avoiding
    inconsistent behaviour when unselecting the last selected field.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739756

 src/scan_dialog.c |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)
---
diff --git a/src/scan_dialog.c b/src/scan_dialog.c
index 450d3d9..3eb74d7 100644
--- a/src/scan_dialog.c
+++ b/src/scan_dialog.c
@@ -1770,13 +1770,15 @@ Process_Fields_First_Letters_Check_Button_Toggled (EtScanDialog *self)
  * Set sensitive state of the processing check boxes : if no one is selected => all disabled
  */
 static void
-Select_Fields_Set_Sensitive (EtScanDialog *self)
+on_process_fields_changed (EtScanDialog *self,
+                           gchar *key,
+                           GSettings *settings)
 {
     EtScanDialogPrivate *priv;
 
     priv = et_scan_dialog_get_instance_private (self);
 
-    if (g_settings_get_flags (MainSettings, "process-fields") != 0)
+    if (g_settings_get_flags (settings, key) != 0)
     {
         gtk_widget_set_sensitive(GTK_WIDGET(priv->process_convert_to_space_toggle),     TRUE);
         gtk_widget_set_sensitive(GTK_WIDGET(priv->process_convert_to_underscores_toggle),         TRUE);
@@ -2445,12 +2447,12 @@ create_scan_dialog (EtScanDialog *self)
                                           et_settings_flags_toggle_get,
                                           et_settings_flags_toggle_set, widget,
                                           NULL);
-            g_signal_connect_swapped (G_OBJECT (widget), "toggled",
-                                      G_CALLBACK (Select_Fields_Set_Sensitive),
-                                      self);
         }
     }
 
+    g_signal_connect_swapped (MainSettings, "changed::process-fields",
+                              G_CALLBACK (on_process_fields_changed), self);
+
     /* Group: character conversion */
     priv->process_convert_to_space_toggle = GTK_WIDGET (gtk_builder_get_object (builder, 
"convert_space_radio"));
     priv->process_convert_to_underscores_toggle = GTK_WIDGET (gtk_builder_get_object (builder, 
"convert_underscores_radio"));
@@ -2546,7 +2548,7 @@ create_scan_dialog (EtScanDialog *self)
     g_settings_bind (MainSettings, "process-remove-duplicate-spaces",
                      priv->process_insert_one_space_toggle, "active",
                      G_SETTINGS_BIND_DEFAULT);
-    Select_Fields_Set_Sensitive (self);
+    on_process_fields_changed (self, "process-fields", MainSettings);
 
     /*
      * Frame to display codes legend