[easytag] Avoid a crash when reading empty FLAC tags



commit 6a17785ed0dfcdb1638aafd1227bc5c8e649d3ba
Author: David King <amigadave amigadave com>
Date:   Thu Nov 6 07:59:32 2014 +0000

    Avoid a crash when reading empty FLAC tags
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739694

 src/tags/flac_tag.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/src/tags/flac_tag.c b/src/tags/flac_tag.c
index 57c4303..be75f1a 100644
--- a/src/tags/flac_tag.c
+++ b/src/tags/flac_tag.c
@@ -739,7 +739,8 @@ flac_tag_read_file_tag (GFile *file,
       && FileTag->encoded_by  == NULL
       && FileTag->picture     == NULL)
     {
-        gboolean rc = id3tag_read_file_tag (file, FileTag, NULL);
+        /* Ignore errors. */
+        id3tag_read_file_tag (file, FileTag, NULL);
 
         // If an ID3 tag has been found (and no FLAC tag), we mark the file as
         // unsaved to rewrite a flac tag.
@@ -763,9 +764,6 @@ flac_tag_read_file_tag (GFile *file,
         {
             FileTag->saved = FALSE;
         }
-
-        g_free(filename_utf8);
-        return rc;
     }
 #endif
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]