[gnome-online-accounts/gnome-3-12] kerberos: Plug leak in error handling
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-online-accounts/gnome-3-12] kerberos: Plug leak in error handling
- Date: Tue, 4 Nov 2014 12:46:34 +0000 (UTC)
commit ff99c54d3fb8bcc243ba24b760d201e830ec394a
Author: Ray Strode <rstrode redhat com>
Date: Wed Oct 29 16:13:11 2014 -0400
kerberos: Plug leak in error handling
It's a little tedious to convert a kerberos error into a GError,
so there's a helper function to do it: set_error_from_krb5_error_code
That helper function leaks the format string use for constructing the
GError's message.
This commit fixes that.
https://bugzilla.gnome.org/show_bug.cgi?id=739590
src/goaidentity/goakerberosidentity.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/goaidentity/goakerberosidentity.c b/src/goaidentity/goakerberosidentity.c
index c7d24f3..2352e6c 100644
--- a/src/goaidentity/goakerberosidentity.c
+++ b/src/goaidentity/goakerberosidentity.c
@@ -321,6 +321,7 @@ set_error_from_krb5_error_code (GoaKerberosIdentity *self,
va_start (args, format);
literal_message = g_strdup_vprintf (expanded_format, args);
va_end (args);
+ g_free (expanded_format);
g_set_error_literal (error, GOA_IDENTITY_ERROR, code, literal_message);
g_free (literal_message);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]