[easytag] Improve copying extra tags between files



commit ba3305e91043f1960c94f6343d343adf50060a2b
Author: David King <amigadave amigadave com>
Date:   Tue Nov 4 08:40:46 2014 +0000

    Improve copying extra tags between files
    
    Prepend to the GList, and then reverse it afterwards.

 src/et_core.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/et_core.c b/src/et_core.c
index 028ae12..108e03b 100644
--- a/src/et_core.c
+++ b/src/et_core.c
@@ -2560,7 +2560,7 @@ ET_Free_Artist_Album_File_List (void)
 /*
  * Duplicate the 'other' list
  */
-static gboolean
+static void
 ET_Copy_File_Tag_Item_Other_Field (const ET_File *ETFile,
                                    File_Tag *FileTag)
 {
@@ -2571,11 +2571,11 @@ ET_Copy_File_Tag_Item_Other_Field (const ET_File *ETFile,
 
     for (l = FileTagCur->other; l != NULL; l = g_list_next (l))
     {
-        FileTag->other = g_list_append (FileTag->other,
-                                        g_strdup ((gchar *)l->data));
+        FileTag->other = g_list_prepend (FileTag->other,
+                                         g_strdup ((gchar *)l->data));
     }
 
-    return TRUE;
+    FileTag->other = g_list_reverse (FileTag->other);
 }
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]