[gvfs] sftp: Fail properly if set_attribute type is wrong



commit 9be61011c012db38ea73484579375999af3c4236
Author: Ross Lagerwall <rosslagerwall gmail com>
Date:   Tue May 27 18:36:54 2014 +0100

    sftp: Fail properly if set_attribute type is wrong
    
    If given an invalid type when setting unix::mode in try_set_attribute,
    don't try and change the mode after failing the job.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730844

 daemon/gvfsbackendsftp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/daemon/gvfsbackendsftp.c b/daemon/gvfsbackendsftp.c
index fcefbd2..d93bd9a 100644
--- a/daemon/gvfsbackendsftp.c
+++ b/daemon/gvfsbackendsftp.c
@@ -4858,6 +4858,7 @@ try_set_attribute (GVfsBackend *backend,
                         G_IO_ERROR_INVALID_ARGUMENT,
                         "%s",
                         _("Invalid attribute type (uint32 expected)"));
+      return TRUE;
     }
 
   command = new_command_stream (op_backend,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]