[libgdata/libgdata-0-14] contacts: Remove a redundant xmlFree() call



commit 8276acd6bd11a08663fd78a8bcf4a1e06b996778
Author: Philip Withnall <philip tecnocode co uk>
Date:   Fri May 16 10:00:36 2014 +0100

    contacts: Remove a redundant xmlFree() call
    
    It was always called on NULL, and was confusing Coverity.
    
    Coverity issue: #59764

 gdata/services/contacts/gdata-contacts-contact.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/gdata/services/contacts/gdata-contacts-contact.c 
b/gdata/services/contacts/gdata-contacts-contact.c
index 4ec9e58..cb7c4d1 100644
--- a/gdata/services/contacts/gdata-contacts-contact.c
+++ b/gdata/services/contacts/gdata-contacts-contact.c
@@ -922,7 +922,6 @@ parse_xml (GDataParsable *parsable, xmlDoc *doc, xmlNode *node, gpointer user_da
                        /* Note that while we require the property to be present, we don't require it to be 
non-empty. See bgo#648058 */
                        name = xmlGetProp (node, (xmlChar*) "key");
                        if (name == NULL) {
-                               xmlFree (name);
                                return gdata_parser_error_required_property_missing (node, "key", error);
                        }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]