[banshee] build: simplify uninstall-hook target in root folder



commit 7c42e7a820f7f75088bf5756468a1e7666a1c8d2
Author: Andrés G. Aragoneses <knocte gmail com>
Date:   Sun May 18 15:40:31 2014 +0200

    build: simplify uninstall-hook target in root folder
    
    The way to check if $(pkglibdir) exists can be simplified to just
    check for its existence now. I guess `find` was used in combination
    with `wc` before because it could happen that there were leftover
    subfolders not properly uninstalled, which would make `rmdir` error
    out.
    
    However, this situation has been fixed in [1], so we can now
    assume that $(pkglibdir) doesn't contain any elements when this
    hook happens (if it contains any elements, it will be a bug in the
    build infrastructure, so with this `rmdir` would fail fast, which
    is a good thing).
    
    [1] https://git.gnome.org/browse/banshee/commit/?id=50257fafdc0077754cb2cb155db048261fdfbb73

 Makefile.am |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
---
diff --git a/Makefile.am b/Makefile.am
index 3a533e6..6fbd6ff 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,9 +15,7 @@ clean-local:
 
 uninstall-hook:
        if test -d $(pkglibdir); then \
-               if test `find $(pkglibdir) | wc -l` -eq 1; then \
-                       rmdir $(pkglibdir); \
-               fi \
+               rmdir $(pkglibdir); \
        fi
 
 dist-hook:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]