[gnumeric] Improve chart roundtrip through ODF. [#728197]



commit 693e391bfc94322759defe862f00288f2aa4e8dd
Author: Andreas J. Guelzow <aguelzow pyrshep ca>
Date:   Thu May 15 19:59:49 2014 -0600

    Improve chart roundtrip through ODF. [#728197]
    
    2014-05-15  Andreas J. Guelzow <aguelzow pyrshep ca>
    
        * openoffice-write.c (odf_write_interpolation_attribute): correctly write
        the skip-invalid extension

 NEWS                                  |    1 +
 plugins/openoffice/ChangeLog          |    5 +++++
 plugins/openoffice/openoffice-write.c |    4 ++--
 3 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/NEWS b/NEWS
index 9b1ae33..3501e69 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,7 @@ Gnumeric 1.12.16
 
 Andreas:
        * Fix database-range import from ODF. [#730197]
+       * Improve chart roundtrip through ODF. [#728197]
 
 Morten:
        * Start moving off GtkUIManager.
diff --git a/plugins/openoffice/ChangeLog b/plugins/openoffice/ChangeLog
index 6b9791a..107e32f 100644
--- a/plugins/openoffice/ChangeLog
+++ b/plugins/openoffice/ChangeLog
@@ -1,5 +1,10 @@
 2014-05-15  Andreas J. Guelzow <aguelzow pyrshep ca>
 
+       * openoffice-write.c (odf_write_interpolation_attribute): correctly write
+       the skip-invalid extension
+
+2014-05-15  Andreas J. Guelzow <aguelzow pyrshep ca>
+
        * openoffice-read.c (oo_db_range_start): use table:display-filter-buttons
        attribute
 
diff --git a/plugins/openoffice/openoffice-write.c b/plugins/openoffice/openoffice-write.c
index d8211a5..6049ffc 100644
--- a/plugins/openoffice/openoffice-write.c
+++ b/plugins/openoffice/openoffice-write.c
@@ -6497,10 +6497,10 @@ odf_write_interpolation_attribute (GnmOOExport *state,
        if (state->with_extension) {
                gboolean skip_invalid = TRUE;
 
-               if (gnm_object_has_readable_prop (series,
+               if (!gnm_object_has_readable_prop (series,
                                                  "interpolation-skip-invalid",
                                                  G_TYPE_BOOLEAN,
-                                                 &skip_invalid) &&
+                                                 &skip_invalid) ||
                    !skip_invalid)
                        odf_add_bool (state->xml,
                                      GNMSTYLE "interpolation-skip-invalid",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]