[gimp] libgimp: oversight computing thumbnail size



commit c8c105b4df8d474985221015edc7b5d56d8a5696
Author: Massimo Valentini <mvalentini src gnome org>
Date:   Fri May 2 18:44:45 2014 +0200

    libgimp: oversight computing thumbnail size
    
    exporting an image with metadata and thumbnail and with
    an aspect ratio of w:h = 1:5, file-jpeg used to print:
    
    (file-jpeg:): LibGimp-CRITICAL **: gimp_image_get_thumbnail: assertion 'width > 0 && width <= 1024' failed
    (file-jpeg:): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_rowstride: assertion 'GDK_IS_PIXBUF (pixbuf)' failed
    (file-jpeg:): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_n_channels: assertion 'GDK_IS_PIXBUF (pixbuf)' failed
    (file-jpeg:): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_width: assertion 'GDK_IS_PIXBUF (pixbuf)' failed
    (file-jpeg:): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_height: assertion 'GDK_IS_PIXBUF (pixbuf)' failed
    (file-jpeg:): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_pixels: assertion 'GDK_IS_PIXBUF (pixbuf)' failed
    (file-jpeg:): GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

 libgimp/gimpmetadata.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libgimp/gimpmetadata.c b/libgimp/gimpmetadata.c
index 2ed07a2..3e2332c 100644
--- a/libgimp/gimpmetadata.c
+++ b/libgimp/gimpmetadata.c
@@ -449,7 +449,7 @@ gimp_image_metadata_save_finish (gint32                  image_ID,
       else
         {
           thumbh = EXIF_THUMBNAIL_SIZE;
-          thumbw = EXIF_THUMBNAIL_SIZE * image_height / image_width;
+          thumbw = EXIF_THUMBNAIL_SIZE * image_width / image_height;
         }
 
       thumb_pixbuf = gimp_image_get_thumbnail (image_ID, thumbw, thumbh,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]