[opw-web] Don't leak the rejected state



commit 9b6c5c8e9923b796c39a3c9db32cf4ac0e5ae864
Author: Owen W. Taylor <otaylor fishsoup net>
Date:   Tue Mar 18 16:14:15 2014 -0400

    Don't leak the rejected state
    
    Not allowing users to edit rejected proposals leaks the rejected status
    before the selection deadline (and before the proposal might move back
    to the accepted status.) Don't take rejection into account in figuring
    out user permissions.

 utils.php |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)
---
diff --git a/utils.php b/utils.php
index 05b3e0a..8dd24a5 100644
--- a/utils.php
+++ b/utils.php
@@ -131,14 +131,7 @@ class ProjectPermissions {
                 $can_resubmit = $project_data['is_withdrawn'] == 1;
                 $can_delete = true;
             } else if ($is_owner && $role == 's') {
-                if ($project_data['is_accepted'] == 0) {
-                    // Do not let anyone but admins edit rejected projects`
-                    $can_edit = false;
-                    $can_change_organization = false;
-                    $can_withdraw = false;
-                    $can_resubmit = false;
-                    $can_delete = false;
-                } else if ($core->timestamp >= $program_data['dl_mentor']) {
+                if ($core->timestamp >= $program_data['dl_mentor']) {
                     // Past the selection deadline, students cannot edit anything
                     $can_edit = false;
                     $can_change_organization = false;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]