[opw-web] Revert "Force returnUrl to be http not https for OpenID login"
- From: Owen Taylor <otaylor src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [opw-web] Revert "Force returnUrl to be http not https for OpenID login"
- Date: Wed, 19 Mar 2014 04:10:19 +0000 (UTC)
commit e76d4ebc0ddfba0a70a33a3bd6b365d3c4861ebf
Author: Owen W. Taylor <otaylor fishsoup net>
Date: Tue Mar 18 22:55:34 2014 -0400
Revert "Force returnUrl to be http not https for OpenID login"
We needed to force the returnUrl to be http because we weren't
reliably setting HTTP_X_FORWARDED_PROTO.
This reverts commit a4536f703542187f833bcb572025e1ffcee73b4b.
auth/Hybrid/Provider_Model_OpenID.php | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
---
diff --git a/auth/Hybrid/Provider_Model_OpenID.php b/auth/Hybrid/Provider_Model_OpenID.php
index 7145f39..f98301a 100644
--- a/auth/Hybrid/Provider_Model_OpenID.php
+++ b/auth/Hybrid/Provider_Model_OpenID.php
@@ -53,10 +53,6 @@ class Hybrid_Provider_Model_OpenID extends Hybrid_Provider_Model
$this->api->identity = $this->openidIdentifier;
$this->api->returnUrl = $this->endpoint;
- // HACK - for some reason both wordpress.com and google.com seem to be unhappy if the
- // returnUrl is https - this may have something to do with gnome.org's SSL-proxying
- // setup - to get around this for now, just force the protocol to http.
- $this->api->returnUrl = preg_replace('/^https:/', 'http:', $this->endpoint);
$this->api->required = ARRAY(
'namePerson/first' ,
'namePerson/last' ,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]