[gnumeric] Really fix the hyperlink tips persistence. [see #706659]



commit b8f1aee218b8ade22f5c00f6e13bd7c550fbad2c
Author: Jean Brefort <jean brefort normalesup org>
Date:   Sat Mar 15 11:52:55 2014 +0100

    Really fix the hyperlink tips persistence. [see #706659]

 ChangeLog       |    6 ++++++
 NEWS            |    1 +
 src/item-grid.c |    8 +++++---
 3 files changed, 12 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index ca5adc9..59a33ae 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2014-03-15  Jean Brefort  <jean brefort normalesup org>
+
+       * src/item-grid.c (item_grid_realize), (cb_cursor_come_to_rest): move
+       the tooltip where it will not immediatly be destroyed after creation.
+       [really fix #706659]
+
 2014-03-14  Morten Welinder  <terra gnome org>
 
        * src/xml-sax-write.c (xml_write_style): Don't write a font name
diff --git a/NEWS b/NEWS
index 16f8294..0545bd1 100644
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,7 @@ Andreas:
 
 Jean:
        * Fix tooltip position for scale or RTL sheets. [#725941]
+       * Really fix the hyperlink tips persistence. [see #706659]
 
 Morten:
        * Support volatile functions. [#305798]
diff --git a/src/item-grid.c b/src/item-grid.c
index d48ccb7..c3642bf 100644
--- a/src/item-grid.c
+++ b/src/item-grid.c
@@ -211,8 +211,6 @@ item_grid_realize (GocItem *item)
                        gtk_icon_theme_load_icon (gtk_icon_theme_get_default (), "cursor_cross", 32, 0, NULL),
                        17, 17);
        cb_cursor_motion (ig);
-       /* we need to destroy the hlink tip when the state flags change */
-       g_signal_connect_swapped (item->canvas, "state-flags-changed", G_CALLBACK (ig_clear_hlink_tip), item);
 }
 
 static void
@@ -1086,7 +1084,11 @@ cb_cursor_come_to_rest (GnmItemGrid *ig)
                                                 ig->last_x, ig->last_y);
                        ig->tip = gnumeric_create_tooltip (cw);
                        gtk_label_set_text (GTK_LABEL (ig->tip), tiptext);
-                       gnumeric_position_tooltip (ig->tip, wx, wy, TRUE);
+                       /* moving the tip window some pixels from wx,wy in order to
+                        * avoid a leave_notify event that would destroy the tip.
+                        * see #706659 */
+                       gtk_window_move (GTK_WINDOW (gtk_widget_get_toplevel (ig->tip)),
+                                        wx + 10, wy + 10);
                        gtk_widget_show_all (gtk_widget_get_toplevel (ig->tip));
                }
        }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]