[geary] Don't crash when renaming account nickname: Closes bgo#726277



commit e3dabddcf2acacb88430d544507d1d6cca70af7e
Author: Jim Nelson <jim yorba org>
Date:   Thu Mar 13 16:06:32 2014 -0700

    Don't crash when renaming account nickname: Closes bgo#726277
    
    "sidebar-name-changed" signal was not disconnected when dropping
    a Sidebar.Entry from the Tree, meaning that if the Entry was still
    ref'd and its name changed, the Tree was attempting to update an
    Entry it did not hold.

 src/client/sidebar/sidebar-tree.vala |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/client/sidebar/sidebar-tree.vala b/src/client/sidebar/sidebar-tree.vala
index e9eb4db..4d22271 100644
--- a/src/client/sidebar/sidebar-tree.vala
+++ b/src/client/sidebar/sidebar-tree.vala
@@ -591,6 +591,7 @@ public class Sidebar.Tree : Gtk.TreeView {
         entry.pruned(this);
         
         entry.sidebar_tooltip_changed.disconnect(on_sidebar_tooltip_changed);
+        entry.sidebar_name_changed.disconnect(on_sidebar_name_changed);
         entry.sidebar_count_changed.disconnect(on_sidebar_count_changed);
         
         Sidebar.EmphasizableEntry? emphasizable = entry as Sidebar.EmphasizableEntry;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]