GNOME.org
 

[gnome-online-accounts] Remove Twitter support

commit eac46d6de3ba6db904a7dfbe7a82e6db8e12bc4b
Author: Debarshi Ray <debarshir gnome org>
Date:   Tue Sep 4 13:28:36 2012 +0200

    Remove Twitter support
    
    It does not work. There are currently no known applications that use
    it, and we need to get the terms and conditions reviewed by the SFLC
    anyway.
    
    We have been removing it from past stable releases, and it is time to
    remove it from master too. Will be restored once the situation changes.
    
    See: https://bugzilla.gnome.org/660273
         https://bugzilla.gnome.org/721061

 configure.ac                             |   25 ---
 data/icons/16x16/Makefile.am             |    1 -
 data/icons/16x16/goa-account-twitter.png |  Bin 672 -> 0 bytes
 data/icons/22x22/Makefile.am             |    1 -
 data/icons/22x22/goa-account-twitter.png |  Bin 822 -> 0 bytes
 data/icons/24x24/Makefile.am             |    1 -
 data/icons/24x24/goa-account-twitter.png |  Bin 855 -> 0 bytes
 data/icons/32x32/Makefile.am             |    1 -
 data/icons/32x32/goa-account-twitter.png |  Bin 1214 -> 0 bytes
 data/icons/48x48/Makefile.am             |    1 -
 data/icons/48x48/goa-account-twitter.png |  Bin 1687 -> 0 bytes
 doc/goa-docs.xml                         |    1 -
 doc/goa-sections.txt                     |   10 -
 doc/goa.types                            |    1 -
 po/POTFILES.in                           |    1 -
 src/examples/Makefile.am                 |    6 +-
 src/examples/tweet.c                     |   99 ----------
 src/goabackend/Makefile.am               |    1 -
 src/goabackend/goaprovider.c             |    4 -
 src/goabackend/goatwitterprovider.c      |  311 ------------------------------
 src/goabackend/goatwitterprovider.h      |   42 ----
 21 files changed, 1 insertions(+), 505 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index db2aedc..f5c242a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -232,30 +232,6 @@ if test "$enable_owncloud" != "no"; then
   AC_DEFINE(GOA_OWNCLOUD_ENABLED, 1, [Enable ownCloud data provider])
 fi
 
-# Twitter
-AC_ARG_ENABLE([twitter], [AS_HELP_STRING([--enable-twitter], [Enable Twitter provider])], [], 
[enable_twitter=no])
-AC_ARG_WITH(twitter-consumer-key,
-            [AS_HELP_STRING([--with-twitter-consumer-key],
-                            [Twitter OAuth 1.0 consumer key])],
-                            [],
-                            [])
-AC_ARG_WITH(twitter-consumer-secret,
-            [AS_HELP_STRING([--with-twitter-consumer-secret],
-                            [Twitter OAuth 1.0 consumer secret])],
-                            [],
-                            [])
-if test "$with_twitter_consumer_key" = ""; then
-  with_twitter_consumer_key=not_set
-fi
-if test "$with_twitter_consumer_secret" = ""; then
-  with_twitter_consumer_secret=not_set
-fi
-AC_DEFINE_UNQUOTED(GOA_TWITTER_CONSUMER_KEY, ["$with_twitter_consumer_key"], [Twitter OAuth 1.0 consumer 
key])
-AC_DEFINE_UNQUOTED(GOA_TWITTER_CONSUMER_SECRET, ["$with_twitter_consumer_secret"], [Twitter OAuth 1.0 
consumer secret])
-if test "$enable_twitter" != "no"; then
-  AC_DEFINE(GOA_TWITTER_ENABLED, 1, [Enable Twitter data provider])
-fi
-
 # Yahoo
 AC_ARG_ENABLE([yahoo], [AS_HELP_STRING([--enable-yahoo], [Enable Yahoo provider])], [], [enable_yahoo=no])
 AC_ARG_WITH(yahoo-consumer-key,
@@ -537,7 +513,6 @@ echo "
        Microsoft Exchange provider:    ${enable_exchange}
        ownCloud provider:              ${enable_owncloud}
        Kerberos provider:              ${enable_kerberos}
-       Twitter provider:               ${enable_twitter} (OAuth 1.0, key:${with_twitter_consumer_key} 
secret:${with_twitter_consumer_secret})
        Yahoo provider:                 ${enable_yahoo} (OAuth 1.0, key:${with_yahoo_consumer_key} 
secret:${with_yahoo_consumer_secret})
        Facebook provider:              ${enable_facebook} (OAuth 2.0, id:${with_facebook_client_id})
        Windows Live provider:          ${enable_windows_live} (OAuth 2.0, id:${with_windows_live_client_id})
diff --git a/data/icons/16x16/Makefile.am b/data/icons/16x16/Makefile.am
index 1c229bd..712e92c 100644
--- a/data/icons/16x16/Makefile.am
+++ b/data/icons/16x16/Makefile.am
@@ -8,7 +8,6 @@ icon_DATA =                             \
        goa-account-google.png          \
        goa-account-owncloud.png        \
        goa-account-pocket.png          \
-       goa-account-twitter.png         \
        goa-account-yahoo.png           \
        $(NULL)
 
diff --git a/data/icons/22x22/Makefile.am b/data/icons/22x22/Makefile.am
index 0770827..7936883 100644
--- a/data/icons/22x22/Makefile.am
+++ b/data/icons/22x22/Makefile.am
@@ -8,7 +8,6 @@ icon_DATA =                             \
        goa-account-google.png          \
        goa-account-owncloud.png        \
        goa-account-pocket.png          \
-       goa-account-twitter.png         \
        goa-account-yahoo.png           \
        $(NULL)
 
diff --git a/data/icons/24x24/Makefile.am b/data/icons/24x24/Makefile.am
index 6bf589b..71bda53 100644
--- a/data/icons/24x24/Makefile.am
+++ b/data/icons/24x24/Makefile.am
@@ -7,7 +7,6 @@ icon_DATA =                             \
        goa-account-google.png          \
        goa-account-owncloud.png        \
        goa-account-pocket.png          \
-       goa-account-twitter.png         \
        goa-account-flickr.png          \
        goa-account-yahoo.png           \
        $(NULL)
diff --git a/data/icons/32x32/Makefile.am b/data/icons/32x32/Makefile.am
index 4a123e8..e6c7c40 100644
--- a/data/icons/32x32/Makefile.am
+++ b/data/icons/32x32/Makefile.am
@@ -8,7 +8,6 @@ icon_DATA =                             \
        goa-account-google.png          \
        goa-account-owncloud.png        \
        goa-account-pocket.png          \
-       goa-account-twitter.png         \
        goa-account-yahoo.png           \
        $(NULL)
 
diff --git a/data/icons/48x48/Makefile.am b/data/icons/48x48/Makefile.am
index 2c64c72..ce58d39 100644
--- a/data/icons/48x48/Makefile.am
+++ b/data/icons/48x48/Makefile.am
@@ -7,7 +7,6 @@ icon_DATA =                             \
        goa-account-google.png          \
        goa-account-owncloud.png        \
        goa-account-pocket.png          \
-       goa-account-twitter.png         \
        goa-account-flickr.png          \
        goa-account-yahoo.png           \
        $(NULL)
diff --git a/doc/goa-docs.xml b/doc/goa-docs.xml
index 03b3ed4..6567b0e 100644
--- a/doc/goa-docs.xml
+++ b/doc/goa-docs.xml
@@ -171,7 +171,6 @@
       <xi:include href="xml/goawindowsliveprovider.xml"/>
       <xi:include href="xml/goafacebookprovider.xml"/>
       <xi:include href="xml/goayahooprovider.xml"/>
-      <xi:include href="xml/goatwitterprovider.xml"/>
       <xi:include href="xml/goaflickrprovider.xml"/>
       <xi:include href="xml/goatelepathyfactory.xml"/>
       <xi:include href="xml/goatelepathyprovider.xml"/>
diff --git a/doc/goa-sections.txt b/doc/goa-sections.txt
index 92beb27..7f46754 100644
--- a/doc/goa-sections.txt
+++ b/doc/goa-sections.txt
@@ -579,16 +579,6 @@ goa_yahoo_provider_get_type
 </SECTION>
 
 <SECTION>
-<FILE>goatwitterprovider</FILE>
-GoaTwitterProvider
-<SUBSECTION Standard>
-GOA_TWITTER_PROVIDER
-GOA_IS_TWITTER_PROVIDER
-GOA_TYPE_TWITTER_PROVIDER
-goa_twitter_provider_get_type
-</SECTION>
-
-<SECTION>
 <FILE>goaflickrprovider</FILE>
 GoaFlickrProvider
 <SUBSECTION Standard>
diff --git a/doc/goa.types b/doc/goa.types
index 4831f43..c88c0af 100644
--- a/doc/goa.types
+++ b/doc/goa.types
@@ -33,6 +33,5 @@ goa_oauth2_provider_get_type
 goa_google_provider_get_type
 goa_facebook_provider_get_type
 goa_yahoo_provider_get_type
-goa_twitter_provider_get_type
 goa_flickr_provider_get_type
 goa_windows_live_provider_get_type
diff --git a/po/POTFILES.in b/po/POTFILES.in
index e585f21..b39e8f2 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -18,7 +18,6 @@ src/goabackend/goapocketprovider.c
 src/goabackend/goaprovider.c
 src/goabackend/goasmtpauth.c
 src/goabackend/goatelepathyprovider.c
-src/goabackend/goatwitterprovider.c
 src/goabackend/goautils.c
 src/goabackend/goawebview.c
 src/goabackend/goawindowsliveprovider.c
diff --git a/src/examples/Makefile.am b/src/examples/Makefile.am
index 7ee5a8a..5fffefa 100644
--- a/src/examples/Makefile.am
+++ b/src/examples/Makefile.am
@@ -15,7 +15,7 @@ INCLUDES =                                                    \
        $(WARN_CFLAGS)                                          \
        $(NULL)
 
-noinst_PROGRAMS = list-providers list-accounts tweet add-pocket
+noinst_PROGRAMS = list-providers list-accounts add-pocket
 
 list_providers_SOURCES = list-providers.c
 list_providers_CFLAGS = $(GLIB_CFLAGS) $(GTK_CFLAGS)
@@ -25,10 +25,6 @@ list_accounts_SOURCES = list-accounts.c
 list_accounts_CFLAGS = $(GLIB_CFLAGS)
 list_accounts_LDADD = $(GLIB_LIBS) ../goa/libgoa-1.0.la
 
-tweet_SOURCES = tweet.c
-tweet_CFLAGS = $(GLIB_CFLAGS) $(REST_CFLAGS)
-tweet_LDADD = $(GLIB_LIBS) $(REST_LIBS) ../goa/libgoa-1.0.la
-
 add_pocket_SOURCES = add-pocket.c
 add_pocket_CFLAGS = $(GLIB_CFLAGS) $(REST_CFLAGS)
 add_pocket_LDADD = $(GLIB_LIBS) $(REST_LIBS) ../goa/libgoa-1.0.la
diff --git a/src/goabackend/Makefile.am b/src/goabackend/Makefile.am
index 183223d..17da5c3 100644
--- a/src/goabackend/Makefile.am
+++ b/src/goabackend/Makefile.am
@@ -73,7 +73,6 @@ libgoa_backend_1_0_la_SOURCES =                                               \
        goaimapsmtpprovider.h           goaimapsmtpprovider.c           \
        goaowncloudprovider.h           goaowncloudprovider.c           \
        goayahooprovider.h              goayahooprovider.c              \
-       goatwitterprovider.h            goatwitterprovider.c            \
        goaflickrprovider.h             goaflickrprovider.c             \
        goawindowsliveprovider.h        goawindowsliveprovider.c        \
        goatelepathyfactory.h           goatelepathyfactory.c           \
diff --git a/src/goabackend/goaprovider.c b/src/goabackend/goaprovider.c
index a06a40a..f2aefac 100644
--- a/src/goabackend/goaprovider.c
+++ b/src/goabackend/goaprovider.c
@@ -32,7 +32,6 @@
 #include "goaimapsmtpprovider.h"
 #include "goaowncloudprovider.h"
 #include "goayahooprovider.h"
-#include "goatwitterprovider.h"
 #include "goaflickrprovider.h"
 #include "goawindowsliveprovider.h"
 #include "goatelepathyfactory.h"
@@ -800,9 +799,6 @@ ensure_builtins_loaded (void)
 #ifdef GOA_YAHOO_ENABLED
       type = GOA_TYPE_YAHOO_PROVIDER;
 #endif
-#ifdef GOA_TWITTER_ENABLED
-      type = GOA_TYPE_TWITTER_PROVIDER;
-#endif
 #ifdef GOA_TELEPATHY_ENABLED
       type = GOA_TYPE_TELEPATHY_FACTORY;
 #endif
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]