[gnome-packagekit] Fixed first character eating
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-packagekit] Fixed first character eating
- Date: Sun, 29 Jun 2014 16:52:09 +0000 (UTC)
commit 34d15dac8737768e5b414114cfe95ca2fae05c39
Author: Ignaker <ignaker gmail com>
Date: Fri Aug 23 16:53:30 2013 +0200
Fixed first character eating
Search "entry_changed" and groups "treeview_changed" callbacks were
calling (indirectly) each other: text changed cleared tree selection, tree
changed cleared text entry.
Changed gpk_application_groups_treeview_changed_cb to clear text
only if selection exists.
Changed gpk_application_text_changed_cb to clear selection only if text
is empty.
https://bugzilla.gnome.org/show_bug.cgi?id=705089
src/gpk-application.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/src/gpk-application.c b/src/gpk-application.c
index 34ca06e..24d4a00 100644
--- a/src/gpk-application.c
+++ b/src/gpk-application.c
@@ -1748,7 +1748,8 @@ gpk_application_text_changed_cb (GtkEntry *entry, GpkApplicationPrivate *priv)
GtkTreeSelection *selection;
/* clear group selection if we have the tab */
- if (pk_bitfield_contain (priv->roles, PK_ROLE_ENUM_SEARCH_GROUP)) {
+ if (pk_bitfield_contain (priv->roles, PK_ROLE_ENUM_SEARCH_GROUP) &&
+ gtk_entry_get_text_length (entry) > 0) {
treeview = GTK_TREE_VIEW (gtk_builder_get_object (priv->builder, "treeview_groups"));
selection = gtk_tree_view_get_selection (treeview);
gtk_tree_selection_unselect_all (selection);
@@ -2077,12 +2078,12 @@ gpk_application_groups_treeview_changed_cb (GtkTreeSelection *selection, GpkAppl
gpk_application_clear_details (priv);
gpk_application_clear_packages (priv);
- /* clear the search text if we clicked the group array */
- entry = GTK_ENTRY (gtk_builder_get_object (priv->builder, "entry_text"));
- gtk_entry_set_text (entry, "");
-
/* This will only work in single or browse selection mode! */
if (gtk_tree_selection_get_selected (selection, &model, &iter)) {
+ /* clear the search text if we clicked the group array */
+ entry = GTK_ENTRY (gtk_builder_get_object (priv->builder, "entry_text"));
+ gtk_entry_set_text (entry, "");
+
g_free (priv->search_group);
gtk_tree_model_get (model, &iter,
GROUPS_COLUMN_ID, &priv->search_group,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]