[gtk+] GtkMenuTrackerItem: Plug a memory leak



commit 6f0951845f819a082d7428f2c2b4fa12d2ef7788
Author: Matthias Clasen <mclasen redhat com>
Date:   Sat Jun 28 22:39:43 2014 -0400

    GtkMenuTrackerItem: Plug a memory leak
    
    gtk_menu_tracker_get_[verb_]icon both return a reference,
    so don't use g_value_set_object, which adds another one.

 gtk/gtkmenutrackeritem.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/gtk/gtkmenutrackeritem.c b/gtk/gtkmenutrackeritem.c
index 232ac37..799f929 100644
--- a/gtk/gtkmenutrackeritem.c
+++ b/gtk/gtkmenutrackeritem.c
@@ -164,10 +164,10 @@ gtk_menu_tracker_item_get_property (GObject    *object,
       g_value_set_string (value, gtk_menu_tracker_item_get_label (self));
       break;
     case PROP_ICON:
-      g_value_set_object (value, gtk_menu_tracker_item_get_icon (self));
+      g_value_take_object (value, gtk_menu_tracker_item_get_icon (self));
       break;
     case PROP_VERB_ICON:
-      g_value_set_object (value, gtk_menu_tracker_item_get_verb_icon (self));
+      g_value_take_object (value, gtk_menu_tracker_item_get_verb_icon (self));
       break;
     case PROP_SENSITIVE:
       g_value_set_boolean (value, gtk_menu_tracker_item_get_sensitive (self));
@@ -199,6 +199,7 @@ gtk_menu_tracker_item_finalize (GObject *object)
   GtkMenuTrackerItem *self = GTK_MENU_TRACKER_ITEM (object);
 
   g_free (self->action_namespace);
+  g_free (self->action_and_target);
 
   if (self->observable)
     g_object_unref (self->observable);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]