[gnome-software] Don't show a spinner for addon install progress
- From: Kalev Lember <klember src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] Don't show a spinner for addon install progress
- Date: Tue, 24 Jun 2014 13:33:47 +0000 (UTC)
commit 8d0ee13566263026ad8a5971d6440f11aea5fee5
Author: Kalev Lember <kalevlember gmail com>
Date: Tue Jun 24 16:32:14 2014 +0300
Don't show a spinner for addon install progress
Allan Day pointed out on IRC that having both "Installing", "Removing"
labels and the spinner is a bit too much.
src/gs-app-addon-row.c | 15 ---------------
src/gs-app-addon-row.ui | 34 +++++-----------------------------
2 files changed, 5 insertions(+), 44 deletions(-)
---
diff --git a/src/gs-app-addon-row.c b/src/gs-app-addon-row.c
index 91fa471..8eb3bcb 100644
--- a/src/gs-app-addon-row.c
+++ b/src/gs-app-addon-row.c
@@ -34,7 +34,6 @@ struct _GsAppAddonRowPrivate
GtkWidget *name_box;
GtkWidget *name_label;
GtkWidget *description_label;
- GtkWidget *spinner;
GtkWidget *label;
GtkWidget *checkbox;
};
@@ -116,19 +115,6 @@ gs_app_addon_row_refresh (GsAppAddonRow *row)
break;
}
- /* update the spinner */
- switch (gs_app_get_state (row->priv->app)) {
- case GS_APP_STATE_INSTALLING:
- case GS_APP_STATE_REMOVING:
- gtk_spinner_start (GTK_SPINNER (priv->spinner));
- gtk_widget_set_visible (priv->spinner, TRUE);
- break;
- default:
- gtk_spinner_stop (GTK_SPINNER (priv->spinner));
- gtk_widget_set_visible (priv->spinner, FALSE);
- break;
- }
-
/* update the checkbox */
switch (gs_app_get_state (row->priv->app)) {
case GS_APP_STATE_QUEUED:
@@ -251,7 +237,6 @@ gs_app_addon_row_class_init (GsAppAddonRowClass *klass)
gtk_widget_class_bind_template_child_private (widget_class, GsAppAddonRow, name_box);
gtk_widget_class_bind_template_child_private (widget_class, GsAppAddonRow, name_label);
gtk_widget_class_bind_template_child_private (widget_class, GsAppAddonRow, description_label);
- gtk_widget_class_bind_template_child_private (widget_class, GsAppAddonRow, spinner);
gtk_widget_class_bind_template_child_private (widget_class, GsAppAddonRow, label);
gtk_widget_class_bind_template_child_private (widget_class, GsAppAddonRow, checkbox);
}
diff --git a/src/gs-app-addon-row.ui b/src/gs-app-addon-row.ui
index f518d45..9f1a71c 100644
--- a/src/gs-app-addon-row.ui
+++ b/src/gs-app-addon-row.ui
@@ -56,39 +56,15 @@
</child>
</object>
<packing>
- <property name="expand">False</property>
+ <property name="expand">True</property>
<property name="fill">True</property>
</packing>
</child>
<child>
- <object class="GtkBox" id="end_box">
- <property name="visible">True</property>
- <property name="orientation">horizontal</property>
- <property name="width_request">180</property>
- <property name="halign">end</property>
- <property name="valign">center</property>
- <child>
- <object class="GtkSpinner" id="spinner">
- <property name="margin_start">12</property>
- <property name="halign">end</property>
- </object>
- <packing>
- <property name="pack_type">end</property>
- <property name="expand">False</property>
- <property name="fill">False</property>
- </packing>
- </child>
- <child>
- <object class="GtkLabel" id="label">
- <property name="margin_start">12</property>
- <property name="halign">end</property>
- </object>
- <packing>
- <property name="pack_type">end</property>
- <property name="expand">False</property>
- <property name="fill">False</property>
- </packing>
- </child>
+ <object class="GtkLabel" id="label">
+ <property name="margin_start">12</property>
+ <property name="width_request">100</property>
+ <property name="xalign">1</property>
</object>
<packing>
<property name="pack_type">end</property>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]