[ostree] [staticanalysis]: Actually check errors on splice() of objects
- From: Colin Walters <walters src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [ostree] [staticanalysis]: Actually check errors on splice() of objects
- Date: Sun, 22 Jun 2014 00:21:44 +0000 (UTC)
commit 54079982d8667f3f908a2f03a11c1c8ee0619839
Author: Colin Walters <walters verbum org>
Date: Sat Jun 21 17:30:11 2014 -0400
[staticanalysis]: Actually check errors on splice() of objects
We were using unsigned size when we should have been using signed,
this means we basically weren't checking for errors on write...ouch.
Luckily if we e.g. hit ENOSPC during a pull, the checksums wouldn't
match and we'd return an error anyways. However when writing an
object, we'd end up silently ignoring it =/
https://bugzilla.gnome.org/show_bug.cgi?id=732020
src/libostree/ostree-repo-commit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c
index 3ae8ae2..68cff05 100644
--- a/src/libostree/ostree-repo-commit.c
+++ b/src/libostree/ostree-repo-commit.c
@@ -365,7 +365,7 @@ write_object (OstreeRepo *self,
gboolean temp_file_is_regular;
gboolean is_symlink = FALSE;
char loose_objpath[_OSTREE_LOOSE_PATH_MAX];
- gsize unpacked_size = 0;
+ gssize unpacked_size = 0;
gboolean indexable = FALSE;
g_return_val_if_fail (expected_checksum || out_csum, FALSE);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]