[gtk+] GtkTreeView: Remove a no-longer-valid optimization



commit 0056d3a6ad8771f98afb61bf603f60ce1b61d10b
Author: Matthias Clasen <mclasen redhat com>
Date:   Thu Jun 19 13:51:25 2014 -0400

    GtkTreeView: Remove a no-longer-valid optimization
    
    The rubberband rendering code was assuming that we just have
    a 1-pixel border and the rest of the rubberband is uniform.
    That is not a safe assumption to make with css-styled
    rubberbands, so remove it.

 gtk/gtktreeview.c |   18 ------------------
 1 files changed, 0 insertions(+), 18 deletions(-)
---
diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index d2b6df0..825279f 100644
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -4553,7 +4553,6 @@ gtk_tree_view_update_rubber_band (GtkTreeView *tree_view)
   gdouble start_x, start_y, offset_x, offset_y, x, y;
   GdkRectangle old_area;
   GdkRectangle new_area;
-  GdkRectangle common;
   cairo_region_t *invalid_region;
   gint bin_x, bin_y;
 
@@ -4584,23 +4583,6 @@ gtk_tree_view_update_rubber_band (GtkTreeView *tree_view)
   invalid_region = cairo_region_create_rectangle (&old_area);
   cairo_region_union_rectangle (invalid_region, &new_area);
 
-  gdk_rectangle_intersect (&old_area, &new_area, &common);
-  if (common.width > 2 && common.height > 2)
-    {
-      cairo_region_t *common_region;
-
-      /* make sure the border is invalidated */
-      common.x += 1;
-      common.y += 1;
-      common.width -= 2;
-      common.height -= 2;
-
-      common_region = cairo_region_create_rectangle (&common);
-
-      cairo_region_subtract (invalid_region, common_region);
-      cairo_region_destroy (common_region);
-    }
-
   gdk_window_invalidate_region (tree_view->priv->bin_window, invalid_region, TRUE);
 
   cairo_region_destroy (invalid_region);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]