[evolution] Bug 731590 - Crash on calendar Copy



commit 45271d47fca8a4ba6927cc428ab41c637da821b4
Author: Milan Crha <mcrha redhat com>
Date:   Tue Jun 17 16:19:17 2014 +0200

    Bug 731590 - Crash on calendar Copy

 calendar/gui/dialogs/copy-source-dialog.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/calendar/gui/dialogs/copy-source-dialog.c b/calendar/gui/dialogs/copy-source-dialog.c
index c948d0c..c7a7b4d 100644
--- a/calendar/gui/dialogs/copy-source-dialog.c
+++ b/calendar/gui/dialogs/copy-source-dialog.c
@@ -142,13 +142,15 @@ dest_source_connected_cb (GObject *source_object,
                        ftd.dest_client = csdd->dest_client;
 
                        for (l = obj_list; l != NULL; l = l->next) {
+                               icalcomp = NULL;
+
                                /* FIXME: process recurrences */
                                /* FIXME: process errors */
-                               e_cal_client_get_object_sync (
+                               if (e_cal_client_get_object_sync (
                                        csdd->dest_client,
                                        icalcomponent_get_uid (l->data),
-                                       NULL, &icalcomp, NULL, NULL);
-                               if (icalcomp != NULL) {
+                                       NULL, &icalcomp, NULL, NULL) &&
+                                   icalcomp != NULL) {
                                        e_cal_client_modify_object_sync (
                                                csdd->dest_client, l->data,
                                                CALOBJ_MOD_ALL, NULL, NULL);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]